add country-coder json [#44] #743
bdonsonar.yml
on: pull_request
Analyze with Sonar
1m 14s
Annotations
6 warnings
|
Analyze with Sonar
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-java@v3, actions/cache@v3, actions/github-script@v6. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
CRITICAL CODE_SMELL:
src/main/java/com/protomaps/basemap/feature/CountryCoder.java#L41
Define a constant instead of duplicating this literal "geometry" 3 times.
rule: java:S1192 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1192&rule_key=java%3AS1192)
issue url: https://sonarcloud.io/project/issues?pullRequest=328&open=AZK8eUjiWDuLyLZ4BE0V&id=protomaps_basemaps
|
|
MAJOR CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Roads.java#L48
Remove this useless assignment to local variable "code".
rule: java:S1854 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1854&rule_key=java%3AS1854)
issue url: https://sonarcloud.io/project/issues?pullRequest=328&open=AZK8eUj_WDuLyLZ4BE0W&id=protomaps_basemaps
|
|
MINOR CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Roads.java#L48
Remove this unused "code" local variable.
rule: java:S1481 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1481&rule_key=java%3AS1481)
issue url: https://sonarcloud.io/project/issues?pullRequest=328&open=AZK8eUj_WDuLyLZ4BE0X&id=protomaps_basemaps
|
|
MAJOR CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Roads.java#L49
Either remove or fill this block of code.
rule: java:S108 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS108&rule_key=java%3AS108)
issue url: https://sonarcloud.io/project/issues?pullRequest=328&open=AZK8eUj_WDuLyLZ4BE0Y&id=protomaps_basemaps
|
|
MAJOR CODE_SMELL:
src/test/java/com/protomaps/basemap/feature/CountryCoderTest.java#L20
Replace these 3 tests with a single Parameterized one.
rule: java:S5976 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS5976&rule_key=java%3AS5976)
issue url: https://sonarcloud.io/project/issues?pullRequest=328&open=AZK8eUjGWDuLyLZ4BE0U&id=protomaps_basemaps
|