wip multiexpression #391
bdon
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
sonar.yml
on: pull_request
Analyze with Sonar
1m 28s
Annotations
10 warnings
|
MAJOR CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Landuse.java#L27
Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()'
rule: java:S6204 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS6204&rule_key=java%3AS6204)
issue url: https://sonarcloud.io/project/issues?pullRequest=109&open=AYuyg3x4NGgAITLxPHlb&id=protomaps_basemaps
|
|
MINOR CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Landuse.java#L31
Make LANDUSE_KIND a static final constant or non-public and provide accessors if needed.
rule: java:S1104 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1104&rule_key=java%3AS1104)
issue url: https://sonarcloud.io/project/issues?pullRequest=109&open=AYuyg3x4NGgAITLxPHlW&id=protomaps_basemaps
|
|
MINOR CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Landuse.java#L31
Make this "public static LANDUSE_KIND" field final
rule: java:S1444 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1444&rule_key=java%3AS1444)
issue url: https://sonarcloud.io/project/issues?pullRequest=109&open=AYuyg3x4NGgAITLxPHlX&id=protomaps_basemaps
|
|
MINOR CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Landuse.java#L31
Rename this field "LANDUSE_KIND" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
rule: java:S3008 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS3008&rule_key=java%3AS3008)
issue url: https://sonarcloud.io/project/issues?pullRequest=109&open=AYuyg3x4NGgAITLxPHlY&id=protomaps_basemaps
|
|
CRITICAL CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Landuse.java#L35
Define a constant instead of duplicating this literal "pedestrian" 3 times.
rule: java:S1192 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1192&rule_key=java%3AS1192)
issue url: https://sonarcloud.io/project/issues?pullRequest=109&open=AYuyg3x4NGgAITLxPHlV&id=protomaps_basemaps
|
|
CRITICAL CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Landuse.java#L39
Define a constant instead of duplicating this literal "landuse" 7 times.
rule: java:S1192 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1192&rule_key=java%3AS1192)
issue url: https://sonarcloud.io/project/issues?pullRequest=109&open=AYuyg3x4NGgAITLxPHlU&id=protomaps_basemaps
|
|
MINOR CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Landuse.java#L59
Rename this field "US_OPERATOR" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
rule: java:S3008 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS3008&rule_key=java%3AS3008)
issue url: https://sonarcloud.io/project/issues?pullRequest=109&open=AYuyg3x4NGgAITLxPHlZ&id=protomaps_basemaps
|
|
MINOR CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Landuse.java#L64
Rename this field "PROTECTION_TITLE" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
rule: java:S3008 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS3008&rule_key=java%3AS3008)
issue url: https://sonarcloud.io/project/issues?pullRequest=109&open=AYuyg3x4NGgAITLxPHla&id=protomaps_basemaps
|
|
MAJOR CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Landuse.java#L91
This block of commented-out lines of code should be removed.
rule: java:S125 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS125&rule_key=java%3AS125)
issue url: https://sonarcloud.io/project/issues?pullRequest=109&open=AYuyg3x4NGgAITLxPHld&id=protomaps_basemaps
|
|
MINOR CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Landuse.java#L98
Use isEmpty() to check whether the collection is empty or not.
rule: java:S1155 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1155&rule_key=java%3AS1155)
issue url: https://sonarcloud.io/project/issues?pullRequest=109&open=AYvH6uEk97dqnWApOL_i&id=protomaps_basemaps
|