Skip to content

Commit

Permalink
don't require man_made=bridge outlines have area=yes [#180] (#182)
Browse files Browse the repository at this point in the history
* don't require man_made=bridge outlines have area=yes [#180]

* Tiles v3.0.1 - add bridge area example [#182]

* make landuse filters more concise
  • Loading branch information
bdon authored Jan 2, 2024
1 parent 8788ead commit 65abca7
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 5 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
Tiles v3.0.1
------
- Fix pedestrian bridge areas

Styles v2.0.0-alpha.4
------
- Fix ordering issues related to pedestrian bridges.
Expand All @@ -7,6 +11,10 @@ Tiles v3.0.0-pre4
- Fix appearance of NE boundaries at low zooms.
- Add `pmap:kind`=`bus_stop` to POIs. via [@eikes](https://github.com/eikes)

Tiles v3.0.0-pre3
------
- Make `disputed` tag on boundaries consistent [#190]

v3.0.0-pre1
------
- **Release date:** 2023-07-10.
Expand Down
11 changes: 9 additions & 2 deletions app/src/examples.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
{
"name": "taiwan-z8",
"description": "Compare the appearance of highways",
"tags": ["highway", "cjk"],
"tags": ["highway", "cjk", "tw"],
"center": [121.333, 24.32],
"zoom": 8
},
{
"name": "taiwan-z16-buildings",
"description": "Compare the appearance of buildings",
"tags": ["buildings", "cjk"],
"tags": ["building", "cjk", "tw"],
"center": [121.4818, 25.0271],
"zoom": 16
},
Expand All @@ -26,5 +26,12 @@
"tags": [],
"center": [0, 0],
"zoom": 2
},
{
"name": "zurich-bridges",
"description": "Pedestrian bridge tagged as area",
"tags": ["bridge", "ch"],
"center": [8.54252, 47.376925],
"zoom": 17
}
]
2 changes: 1 addition & 1 deletion tiles/src/main/java/com/protomaps/basemap/Basemap.java
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public String description() {

@Override
public String version() {
return "3.0.0-pre3";
return "3.0.1";
}

@Override
Expand Down
4 changes: 2 additions & 2 deletions tiles/src/main/java/com/protomaps/basemap/layers/Landuse.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ public void processFeature(SourceFeature sf, FeatureCollector features) {
sf.hasTag("landuse", "recreation_ground", "industrial", "brownfield", "railway", "cemetery", "commercial",
"grass", "orchard", "farmland", "farmyard", "residential", "military") ||
sf.hasTag("leisure", "park", "garden", "golf_course", "dog_park", "playground", "pitch", "nature_reserve") ||
sf.hasTag("man_made", "pier") ||
sf.hasTag("man_made", "pier", "bridge") ||
sf.hasTag("natural", "beach") ||
// TODO: (nvkelso 20230622) This use of the place tag here is dubious, though paired with "residential"
sf.hasTag("place", "neighbourhood") ||
sf.hasTag("railway", "platform") ||
sf.hasTag("tourism", "zoo") ||
(sf.hasTag("area", "yes") &&
(sf.hasTag("highway", "pedestrian", "footway") || sf.hasTag("man_made", "bridge"))))) {
(sf.hasTag("highway", "pedestrian", "footway"))))) {
String kind = "other";
if (sf.hasTag("aeroway", "aerodrome")) {
kind = sf.getString("aeroway");
Expand Down

0 comments on commit 65abca7

Please sign in to comment.