bus_stop zoom off by 1 [#163] #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
|
Yes, we could straighten this out. In the POIs layer we're setting the kind min_zooms to the 512px values (so -1 from what is in Tilezen, to then increase them on export)... also so setting the zoomRange is more straight forward.
I think the other layers also follow this pattern? |
nvkelso
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nvkelso @eikes
We should document how this works at https://docs.protomaps.com/basemaps/layers
notably, we need to be consistent about the mismatch between 256px NE/Leaflet zooms and MapLibre zooms. when we want bus stops to display at Z18 (MapLibre) we encode min_zoom = 17 in the tiles?