Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use ne_10m scale for boundaries [#119] #177

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Only use ne_10m scale for boundaries [#119] #177

merged 1 commit into from
Nov 9, 2023

Conversation

bdon
Copy link
Member

@bdon bdon commented Nov 9, 2023

  • We do our own generalization in code, so we don't need the generalized tables.

Fixes duplicate boundaries where multiple ne versions don't match up @nvkelso

Before: (exaggerated overzoom)

Screenshot 2023-11-10 at 07 32 22

After:

Screenshot 2023-11-10 at 07 33 10

@bdon
Only use ne_10m scale for boundaries [#119]
58654c2 
* We do our own generalization in code, so we don't need the generalized tables.
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@bdon bdon merged commit e7fa1b9 into main Nov 9, 2023
5 checks passed
@bdon bdon deleted the ne-boundaries-10m-only branch November 9, 2023 23:42
@nvkelso
Copy link
Collaborator

nvkelso commented Nov 9, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdon @nvkelso