Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set text-justify: auto on localities that might use a townspot symbol. #313

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

bdon
Copy link
Member

@bdon bdon commented Oct 9, 2024

Copy link

sonarqubecloud bot commented Oct 9, 2024

@wipfli
Copy link
Collaborator

wipfli commented Oct 9, 2024

Looks good to me, thanks!

Just to make sure that everyone is aware of the following detail: When a label consists of multiple scripts, e.g. when you set the target language to Greek and you look at Switzerland where all labels are Latin, then

  • if name:el is present, it will show a label with two lines, e.g. Ζυρίχη\nZürich
  • if name:el is not present, it will show an empty line and then the local name, e.g. \nSchaffhausen

So the symbolizer is either to the left or to the top left of the text. If think that looks good but it is something one needs to be aware of...

image

@bdon
Copy link
Member Author

bdon commented Oct 9, 2024

I would prefer the text is correctly aligned when a single line, and was looking for ways to fix it; it seems like we need a way to make the newline conditional, or somehow move the newline into the case statement of the second line?

@bdon bdon merged commit df57222 into main Oct 9, 2024
4 checks passed
@bdon bdon deleted the places-text-justify branch October 9, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants