Change kind
attribute of OSMData sourced-water to ocean
#330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #329
Let me preface by saying I don't know Java and I'm not very familiar with this codebase, so please excuse any amateur mistakes or oversights. I've marked this PR as a draft to ensure nobody mistakes me for someone who knows what they're doing.
As described in #329, the value of
kind
for oceanic features switches fromocean
in z5 towater
in z6. I think this inconsistency at different zoom levels is undesirable, and it precludes data users from being able to treat oceans differently from inland water. For example, in my own case, I'm wanting to use inland water data from the USGS rather than OSM for a US-focused map, while still using Natural Earth/OSMData for the oceans, but need a way to differentiate the two by attribute.Since the water from the OSMData source only includes oceans (by design), it should be accurate to tag all water features from this source as
kind: ocean
, which is what this PR does.