Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change kind attribute of OSMData sourced-water to ocean #330

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

dericke
Copy link
Contributor

@dericke dericke commented Nov 4, 2024

Closes #329

Let me preface by saying I don't know Java and I'm not very familiar with this codebase, so please excuse any amateur mistakes or oversights. I've marked this PR as a draft to ensure nobody mistakes me for someone who knows what they're doing.

As described in #329, the value of kind for oceanic features switches from ocean in z5 to water in z6. I think this inconsistency at different zoom levels is undesirable, and it precludes data users from being able to treat oceans differently from inland water. For example, in my own case, I'm wanting to use inland water data from the USGS rather than OSM for a US-focused map, while still using Natural Earth/OSMData for the oceans, but need a way to differentiate the two by attribute.

Since the water from the OSMData source only includes oceans (by design), it should be accurate to tag all water features from this source as kind: ocean, which is what this PR does.

@dericke dericke marked this pull request as ready for review November 5, 2024 02:36
Copy link

sonarqubecloud bot commented Nov 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@bdon bdon merged commit 9656daa into protomaps:main Nov 6, 2024
3 of 4 checks passed
@bdon
Copy link
Member

bdon commented Nov 6, 2024

Good catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

water layer: kind=ocean for zooms > 5 rather than changing to kind=water
2 participants