Bump planetiler to v0.8.4 #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great improvement! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By bumping Planetiler to v0.8.4, we can make use of the new Loop Line Merger in the FeatureMerge.mergeLineStrings function. It breaks small loops which reduces the chances of getting 3+ way junctions are intersections and roundabouts. Previously, the JTS line merging would not be able to merge at such 3+ way junctions and because of that, lines would not get merged at roundabouts and then they would be short and fall out of the tiles in the min length pruning. This led so far to a lot of gaps on
highway=primaryroads in particular.Here are some screenshots:
Before
https://pmtiles.io/?url=https%3A%2F%2Fprotomaps.dev%2F%7Ewipfli%2F365%2Fv4-0.8-SNAPSHOT.pmtiles#map=7.06/46.901/8.791
After
https://pmtiles.io/?url=https%3A%2F%2Fprotomaps.dev%2F%7Ewipfli%2F365%2Fv4-0.8.4-SNAPSHOT.pmtiles#map=7.06/46.901/8.791