Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tilejson fixups #114

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Tilejson fixups #114

merged 3 commits into from
Jan 11, 2024

Conversation

bdon
Copy link
Member

@bdon bdon commented Jan 9, 2024

@mikeocool

  • This makes the serve command consistent with show --tilejson in taking a --public-url option for the base path. This is renamed from --public-hostname because it includes not just the hostname but also the protocol like https:// and possibly a non-root path like https://example.com/tiles.

  • Also makes the above consistent where the TileJSON automatically adds the {z}/{x}/{y}.{ext} onto the end, inferring the tile type from the header, instead of having to present this yourself. @mikeocool any limitation in inferring this automatically?

  • Finally, the TileJSON spec has some optional properties name, description, attribution, version and we omit those keys if empty instead of passing a null in TileJSON.

@bdon bdon merged commit ef87ca0 into main Jan 11, 2024
4 checks passed
@bdon bdon deleted the tilejson-fixups branch January 11, 2024 01:42
@mikeocool
Copy link
Contributor

Late to the party on this one -- but LGTM! I worked the latest release into my tile build pipeline -- and it's great, exactly what i needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants