Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker multi platform support #139

Merged
merged 6 commits into from
Feb 12, 2024
Merged

Docker multi platform support #139

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a3807ac
add docker multiplatform support
jonasengelmann Feb 11, 2024
faaee9d
fix indentation
jonasengelmann Feb 11, 2024
5be182e
add missing runs-on statement
jonasengelmann Feb 11, 2024
f54b66b
avoid build with unknown architecture (docker/build-push-action#820)
jonasengelmann Feb 11, 2024
177dacd
replace docker username variable
jonasengelmann Feb 11, 2024
9554132
Merge branch 'docker-multi-platform' into docker-multi-platform
jonasengelmann Feb 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 20 additions & 29 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,48 +12,39 @@ on:
- 'main'

jobs:
docker-build-ghcr:
docker-build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: docker/metadata-action@v5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like we lose the tagged versions on GHCR/Docker Hub by removing this, right? Is there an example somewhere we can follow that accomplishes this correctly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker/metadata-action@v5 is actually still there, it's here, but done for both images. I tried to follow this example and also tested it on my fork. It pushed to both dockerhub and ghcr.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the actions are not running on this PR, but we'll see, I'll tag a patch release. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Oh, because it was a PR to a PR)

id: meta
with:
images: ghcr.io/${{ github.repository }}
- name: Checkout
uses: actions/checkout@v4
- name: Set up QEMU
uses: docker/setup-qemu-action@v3
- uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- uses: docker/build-push-action@v5
with:
context: .
platforms: linux/amd64, linux/arm64
push: ${{ github.event_name != 'pull_request' }}
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
outputs: type=image,name=target,annotation-index.org.opencontainers.image.description=See https://github.com/protomaps/go-pmtiles for more info.
docker-build-dockerhub:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- uses: docker/metadata-action@v5
id: meta
with:
images: protomaps/go-pmtiles
- name: Set up QEMU
uses: docker/setup-qemu-action@v3
- uses: docker/login-action@v3
images: |
protomaps/go-pmtiles
ghcr.io/${{ github.repository }}
- name: Login to Docker Hub
uses: docker/login-action@v3
with:
username: protomaps
password: ${{ secrets.DOCKER_PASSWORD }}
- uses: docker/build-push-action@v5
- name: Login to Github Container Registry
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Build and push
uses: docker/build-push-action@v5
with:
context: .
platforms: linux/amd64, linux/arm64
platforms: linux/amd64,linux/arm64
push: ${{ github.event_name != 'pull_request' }}
provenance: false
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
outputs: type=image,name=target,annotation-index.org.opencontainers.image.description=See https://github.com/protomaps/go-pmtiles for more info.