Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make frontend work properly with custom context url #2363

Merged
merged 4 commits into from
Aug 1, 2022
Merged

Make frontend work properly with custom context url #2363

merged 4 commits into from
Aug 1, 2022

Conversation

workshur
Copy link
Member

@workshur workshur commented Jul 31, 2022 •
edited
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Jul 31, 2022
@workshur workshur added type/bug Something isn't working scope/frontend status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. and removed status/triage Issues pending maintainers triage labels Aug 1, 2022
@github-actions
Copy link

github-actions bot commented Aug 1, 2022

Custom deployment will be available at http://pr2363.internal.kafka-ui.provectus.io

@workshur workshur removed the status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. label Aug 1, 2022
@github-actions
Copy link

github-actions bot commented Aug 1, 2022

Custom deployment removed

@workshur workshur added the status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. label Aug 1, 2022
@github-actions
Copy link

github-actions bot commented Aug 1, 2022

Custom deployment will be available at http://pr2363.internal.kafka-ui.provectus.io

@Haarolean Haarolean changed the title Add an ability to run app from subfolder Make frontend work properly with custom context url Aug 1, 2022
@Haarolean Haarolean linked an issue Aug 1, 2022 that may be closed by this pull request
Web UI ignores SERVER_SERVLET_CONTEXT_PATH environment variable after #2153 #2346
Closed
@Haarolean Haarolean marked this pull request as ready for review August 1, 2022 15:08
@Haarolean Haarolean requested review from a team as code owners August 1, 2022 15:08
@Haarolean Haarolean removed the status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. label Aug 1, 2022
@github-actions
Copy link

github-actions bot commented Aug 1, 2022

Custom deployment removed

@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.0% 97.0% Coverage
0.0% 0.0% Duplication

@Haarolean Haarolean merged commit c4f9732 into master Aug 1, 2022
@Haarolean Haarolean deleted the bug/no_lazyloading branch August 1, 2022 16:47
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
@workshur @Haarolean
Make frontend work properly with custom context url (provectus#2363)
fed08cb 
* Add an ability to run app from subfolder

* linting

* Fix all the static resources URLs and manifest.json

Co-authored-by: Roman Zabaluev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haarolean Haarolean Haarolean approved these changes

Assignees
No one assigned
Labels
scope/frontend type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web UI ignores SERVER_SERVLET_CONTEXT_PATH environment variable after #2153
2 participants
@workshur @Haarolean