Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue: issues/195 and issues/200 #225

Merged
merged 35 commits into from
Oct 20, 2022
Merged

issue: issues/195 and issues/200 #225

merged 35 commits into from
Oct 20, 2022

Conversation

sub2zero
Copy link
Contributor

sub2zero added 29 commits October 6, 2022 11:44
@sub2zero
init
7eb57f1
@sub2zero
add nginx
f29cd01
@sub2zero
linter fix "deep_check" is not expected here
95d069f
@sub2zero
еуые мукышщт гзвфеу
8526b09
@sub2zero
add example
7ed3063
@sub2zero
deploy external-secrets module
8cc7145
@sub2zero
remove hardcoded
0a22502
@sub2zero
chnage repo url
3bf8cc6
@sub2zero
revert back
ad7fd8b
@sub2zero
try 0.5.9 version of exteranl _secrerts
97f232c
@sub2zero
change repo
4836bd9
@sub2zero
fix for ${chart_repo}
868c687
@sub2zero
change repo
aa97d7d
@sub2zero
ver 0.6.0
6e125fa
@sub2zero
change podSecurityContext
2a21f66
@sub2zero
remove external secrets
350e577
@sub2zero
sample test
5c7acc6
@sub2zero
some clean up
1525f29
@sub2zero
remove tested
6790da1
@sub2zero
add test for infra
132fff8
@sub2zero
срфтпу тфьу ащк еуыеашду
b46cfee
@sub2zero
rework for els module insted sak-k8s
80bcb27
@sub2zero
update eks version
2f37e1f
@sub2zero
test
a3ef3a2
@sub2zero
remove argo chart
e17db24
@sub2zero
revert argocd chart
dfbf349
@sub2zero
remove hello
08d7299
@sub2zero
revert it
c3ba9e9
@sub2zero
add some Readme
dbb4aca
@keywordlabeler keywordlabeler bot added the issue label Oct 19, 2022
@sub2zero sub2zero changed the title Test lab issues/195 and issues/200 Oct 19, 2022
@wallhided wallhided changed the title issues/195 and issues/200 issue: issues/195 and issues/200 Oct 19, 2022
wallhided
wallhided suggested changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@wallhided wallhided left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. Please take a look.

examples/argocd/README.md Outdated Show resolved Hide resolved
examples/argocd/README.md Show resolved Hide resolved
examples/argocd/variables.tf Outdated Show resolved Hide resolved
@sub2zero sub2zero requested a review from wallhided October 20, 2022 10:03
wallhided
wallhided suggested changes Oct 20, 2022
View reviewed changes
examples/argocd/README.md Outdated Show resolved Hide resolved
wallhided
wallhided approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@wallhided wallhided left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallhided wallhided merged commit 85b6c5d into provectus:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallhided wallhided wallhided approved these changes

@RustamGimadiev RustamGimadiev Awaiting requested review from RustamGimadiev

Assignees
No one assigned
Labels
issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sub2zero @wallhided @dmiroshnik