Apply suggestions from Clippy #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harudagondi
suggested changes
Aug 30, 2024
clubby789
force-pushed
the
clippy-fixes
branch
from
ff873e8 to
cc4bf9b
Compare
clubby789
commented
Aug 30, 2024
| /// Arrow constructor which returns a default arrow | ||
| pub fn default() -> Arrow { |
There was a problem hiding this comment.
Clippy now lints against fn default() -> Self not in a Default implementation. While the crate is pre-1.0 and this is very unlikely to affect anyone, this is technically a breaking change, so I can revert if you'd prefer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
IdErrortype to explain invalid namescharsinstead of 1-length stringsFrominstead ofInto