Skip to content

Commit

Permalink
Remove references to perftest
Browse files Browse the repository at this point in the history
Signed-off-by: Rob Hoes <[email protected]>
  • Loading branch information
robhoes committed Dec 4, 2024
1 parent c85270a commit 2b02240
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 12 deletions.
6 changes: 0 additions & 6 deletions ocaml/libs/http-lib/http_client.ml
Original file line number Diff line number Diff line change
Expand Up @@ -200,9 +200,6 @@ let response_of_fd ?(use_fastpath = false) fd =
__FUNCTION__ (Printexc.to_string e) ;
None

(** See perftest/tests.ml *)
let last_content_length = ref 0L

let http_rpc_recv_response use_fastpath error_msg fd =
match response_of_fd ~use_fastpath fd with
| None ->
Expand All @@ -212,9 +209,6 @@ let http_rpc_recv_response use_fastpath error_msg fd =
| ("401" | "403" | "500") as http_code ->
raise (Http_error (http_code, error_msg))
| "200" ->
Option.iter
(fun x -> last_content_length := x)
response.Http.Response.content_length ;
response
| code ->
raise (Http_request_rejected (Printf.sprintf "%s: %s" code error_msg))
Expand Down
3 changes: 0 additions & 3 deletions ocaml/libs/http-lib/http_client.mli
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,3 @@ val rpc :
(** [rpc fd request body f] marshals the HTTP request represented by [request] and [body]
through file descriptor [fd] and then applies the response to [f]. On failure an
exception is thrown. *)

val last_content_length : int64 ref
(** See perftest/tests.ml *)
6 changes: 3 additions & 3 deletions quality-gate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ verify-cert () {

mli-files () {
N=497
# do not count ml files from the tests in ocaml/{tests/perftest/quicktest}
MLIS=$(git ls-files -- '**/*.mli' | grep -vE "ocaml/tests|ocaml/perftest|ocaml/quicktest|ocaml/message-switch/core_test" | xargs -I {} sh -c "echo {} | cut -f 1 -d '.'" \;)
MLS=$(git ls-files -- '**/*.ml' | grep -vE "ocaml/tests|ocaml/perftest|ocaml/quicktest|ocaml/message-switch/core_test" | xargs -I {} sh -c "echo {} | cut -f 1 -d '.'" \;)
# do not count ml files from the tests in ocaml/{tests/quicktest}
MLIS=$(git ls-files -- '**/*.mli' | grep -vE "ocaml/tests|ocaml/quicktest|ocaml/message-switch/core_test" | xargs -I {} sh -c "echo {} | cut -f 1 -d '.'" \;)
MLS=$(git ls-files -- '**/*.ml' | grep -vE "ocaml/tests|ocaml/quicktest|ocaml/message-switch/core_test" | xargs -I {} sh -c "echo {} | cut -f 1 -d '.'" \;)
num_mls_without_mlis=$(comm -23 <(sort <<<"$MLS") <(sort <<<"$MLIS") | wc -l)
if [ "$num_mls_without_mlis" -eq "$N" ]; then
echo "OK counted $num_mls_without_mlis .ml files without an .mli"
Expand Down

0 comments on commit 2b02240

Please sign in to comment.