-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for Pydantic v2 migration #232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of moving and removing all kinds of tests, you could add a second test step where you install the v1 version (since via the poetry.lock file it will probably install v2 for the normal test) and then test? That would validate both usages imo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So now my big question is, why do we need to move all the tests in this PR?
But I am no maintainer, just something that I am remarking
@joostlek The thing is I actually added a unit-test for this, but messed with naming, so it wasn't even detected. If you prefer, I can split PR :) |
I personally think, this PR should just contain the changes for this change, and nothing more. (But again, I'm not a maintainer so I don't do the calls here :) ) |
You're right. I have moved irrelevant changesets to a separate branch — there is actually much more work to do with tests. |
I don't see the benefit in testing against pydantic v1 in roombapy, this is temporary at best. Home Assistant is stuck on v1 for now but that does not warrant roombapy running the tests on v1 as well imo, I'm fine with just yoloing the tests on v2 and live with the deprecation warnings for now. As a the sole maintainer (hehe, plz send help) I'd rather just see the pyproject.toml changes and pydantic v1 compat usage changes in this PR. |
I would like to help maintain this integration, just to keep the home herd of Roomba rolling. As for testing... I can keep an eye on home-assistant/core#99218, so when HA migrates from Pydantic v1, I just drop these workarounds and tests. |
@Orhideous you asked for it :) |
Thanks ❤️ |
Imma craft a release for ha |
See: home-assistant/core#110762
See: home-assistant/core#99218