Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for camel casing #540

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Ekrekr
Copy link

@Ekrekr Ekrekr commented Aug 5, 2024

Introduce support for additional options that come after a second colon, starting with camelCasing of fields.

  • Currently doc_opts takes the form of <type>,<output>:<excludes>
  • This PR introduces the new structure of <type>,<output>:<excludes>:<additional options>.
  • See the update to the --doc_opt comment for the full new structure details.
  • This seems like a clean way to support the new camel_case_fields option, which is both backwards compatible without it being populated, and is forwards compatible with additional options being added.

Additional notes:

  • I've implemented additional options parsing in a very simplistic way, splitting by , can be added later if needed.
  • Passing plugin options seems like the most extensible way to support further additional options.
  • I had to bump the protobuf dependency version for the master branch to build.

Fixes #539 - looking closer, I don't think docs_out is possible, so this implements the desired functionality directly.

@Ekrekr
Copy link
Author

Ekrekr commented Aug 5, 2024

@pseudomuto are you the right person to review? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to use the docs_out flag rather than doc_out
1 participant