Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bounds check for negative states + Add tests #158

Closed
wants to merge 6 commits into from

Conversation

pedromxavier
Copy link
Contributor

This PR aims to address #157

Apparently, the offset computation was already correct but the bounds assertions were still not considering the relative first stage.

Tasks

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.10% 🎉

Comparison is base (a990a4d) 79.85% compared to head (476b9de) 79.96%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   79.85%   79.96%   +0.10%     
==========================================
  Files          21       21              
  Lines        2810     2815       +5     
==========================================
+ Hits         2244     2251       +7     
+ Misses        566      564       -2     
Files Changed Coverage Δ
src/tables/interface.jl 76.53% <57.14%> (+2.57%) ⬆️
src/OpenBinary/reader.jl 80.51% <100.00%> (+0.19%) ⬆️
src/utils.jl 55.55% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaquimg
Copy link
Member

joaquimg commented Aug 3, 2023

The test case is too large 2Mb csv, 1Mb bin, it should be much much smaller.

@pedromxavier
Copy link
Contributor Author

This PR should be closed. Handling variable names became infeasible at this point so I reimplemented the core ideas from scratch in #175, including test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants