Add SQLite compatibility with new module #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermebodin
requested changes
Nov 28, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #190 +/- ##
==========================================
- Coverage 80.11% 79.24% -0.88%
==========================================
Files 21 29 +8
Lines 2872 3272 +400
==========================================
+ Hits 2301 2593 +292
- Misses 571 679 +108 ☔ View full report in Codecov by Sentry. |
guilhermebodin
requested changes
Nov 29, 2023
guilhermebodin
requested changes
Dec 5, 2023
guilhermebodin
requested changes
Dec 6, 2023
guilhermebodin
requested changes
Dec 8, 2023
src/OpenSQL/README.md
Outdated
|
|
||
| - In case of a vector attribute, a Table should be created with its name indicating the name of the Collection and the name of the attribute, separated by `_vector_`, as presented below | ||
|
|
||
| <p style="text-align: center;"> COLLECTION_NAME_vector_ATTRIBUTE_NAME</p> |
There was a problem hiding this comment.
COLLECTION_vector_ATTRIBUTE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows one to create, load and modify a study using SQLite.
A new module
OpenSQLwas created and should be able to function independent from PSRI. Moreover, this new functionality should have the same interface as with the current PSRI data format.That being said, in the file
sql_interface.jl, PSRI functions are overloaded to fit the new module's methods to PSRI's syntax.