Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds readability widget #1331

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

adds readability widget #1331

wants to merge 5 commits into from

Conversation

Smullz622
Copy link
Contributor

Adds the readability widget developed by NC State Libraries

The only customization at this time is changing to psu brand colors.

Current fields are warm background, highlight links, open dyslexic font, and remove images. There's potential in the future to customize further by changing the fields you can toggle on/off (ex. ADHD friendly fonts, etc)

Copy link
Contributor

@ajkiessl ajkiessl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove widget.css and widget.css.map. Ultimately, shakapacker should compile the widget.scss into the application.css and application.css.map and throw that in the public/packs/css directory. Otherwise this looks good!

@ajkiessl
Copy link
Contributor

Also, this should probably be removed in widget.scss:

/*
* to compile run this code from the root of this app
* sass --watch widget.scss:widget.css
*

Since shakapacker will handle this.

@Smullz622 Smullz622 requested a review from ajkiessl July 30, 2024 14:45
Copy link
Contributor

@ajkiessl ajkiessl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants