1050 update branding #1100
Open
1050 update branding #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusts the home page to be well-designed on both large and small screens.
ajkiessl
requested changes
Feb 5, 2025
There was a problem hiding this comment.
I think we should separate to public facing views and the non public facing views in /layouts, so we can just load the PSU assets for the few public pages, and keep the rest of the application the same as before. So application.html.erb would be the same as before, but we'd add another layout public.html.erb for the public/api_docs..home..resources.html.erb views.
Loading the PSU assets in application.htlm.erb, is affecting parts of the application that we don't want it to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1050