Fix compatibility issues with iOS 8/Xcode 6 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that with Swift and iOS 8, the typedef regex_t conflicts with an existing typedef in the iOS8 SDK (/Applications/Xcode6-Beta5.app/Contents/Developer/Platforms/iPhoneSimul ator.platform/Developer/SDKs/iPhoneSimulator8.0.sdk/usr/include). With Objective-C, it has no problems compiling, but there must be a bug in the Swift compiler there is an issue which causes the names to conflict.
XCTAssertEqual cannot compare ranges anymore, so I added a helper function to compare the ranges.
The link was broken, so I fixed it. Changing the SenTestingKit to optional allows the tests to run and pass.
|
Also I realize that this may require modification of the Oniguruma library, but on Macs it's a quick one liner: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that with Swift and iOS 8, the typedef regex_t conflicts with an existing typedef in the iOS8 SDK (which can be found in
/Applications/Xcode6-Beta5.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.0.sdk/usr/include/regex.hon line 110).With Objective-C, it has no problems compiling, but there must be a bug in the Swift compiler there is an issue which causes the names to conflict.
I also applied a fix to the tests that makes them pass (the NSRange comparison behaviour changed) and fixed how SenTestingFramework was linked.
Thanks for writing these bindings!