changes after review part - 3 - fix

pszkamruk-splunk · Nov 29, 2023 · dce9798 · dce9798
1 parent 6fe0ced
commit dce9798
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/ui_tests/pages/groups_page.py b/ui_tests/pages/groups_page.py
@@ -225,23 +225,23 @@ def set_snmp_version(self, snmp_version):
 
     def get_device_port(self, device_ip):
         logger.info(f"get device port: {device_ip}")
-        self._get_group_field_value("port", device_ip)
+        return self._get_group_field_value("port", device_ip)
 
     def get_device_snmp_version(self, device_ip):
         logger.info(f"get device snmp_version: {device_ip}")
-        self._get_group_field_value("snmp_version", device_ip)
+        return self._get_group_field_value("snmp_version", device_ip)
 
     def get_device_community_string(self, device_ip):
         logger.info(f"get device community string: {device_ip}")
-        self._get_group_field_value("community_string", device_ip)
+        return self._get_group_field_value("community_string", device_ip)
 
     def get_device_secret(self, device_ip):
         logger.info(f"get device secret: {device_ip}")
-        self._get_group_field_value("secret", device_ip)
+        return self._get_group_field_value("secret", device_ip)
 
     def get_device_security_engine(self, device_ip):
         logger.info(f"get device security engine {device_ip}")
-        self._get_group_field_value("security_engine", device_ip)
+        return self._get_group_field_value("security_engine", device_ip)
 
     def _get_group_field_value(self, field, device_ip):
         xpath = {

diff --git a/ui_tests/pages/inventory_page.py b/ui_tests/pages/inventory_page.py
@@ -136,15 +136,15 @@ def select_group_inventory_type(self):
 
     def get_host_missing_error(self):
         logger.info(f"Get host missing error")
-        self._get_error_for_missing_or_invalid_inventory_field("host_missing")
+        return self._get_error_for_missing_or_invalid_inventory_field("host_missing")
 
     def get_community_string_missing_error(self):
         logger.info(f"Get community string missing error")
-        self._get_error_for_missing_or_invalid_inventory_field("community_string_missing")
+        return self._get_error_for_missing_or_invalid_inventory_field("community_string_missing")
 
     def get_walk_invalid_value_error(self):
         logger.info(f"Get walk interval invalid value error")
-        self._get_error_for_missing_or_invalid_inventory_field("walk_invalid_value")
+        return self._get_error_for_missing_or_invalid_inventory_field("walk_invalid_value")
 
     def _get_error_for_missing_or_invalid_inventory_field(self, field):
         xpath = {