WidgetWithResizeHandle needs and id

pthom · May 11, 2024 · d55c6cc · d55c6cc
1 parent 75bef57
commit d55c6cc
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/src/hello_imgui/hello_imgui_widgets.h b/src/hello_imgui/hello_imgui_widgets.h
@@ -25,9 +25,10 @@ namespace HelloImGui
     //                    ImPlot::EndPlot();
     //                }
     //            };
-    //            widget_size = widget_with_resize_handle(myWidgetFunction);
+    //            widget_size = widget_with_resize_handle("plot", myWidgetFunction);
     //        }
     ImVec2 WidgetWithResizeHandle(
+        const char* id,
         VoidFunction widgetGuiFunction,
         float handleSizeEm = 1.0f,
         std::optional<VoidFunction> onItemResized = std::nullopt,

diff --git a/src/hello_imgui/impl/hello_imgui_widgets.cpp b/src/hello_imgui/impl/hello_imgui_widgets.cpp
@@ -39,6 +39,7 @@ namespace HelloImGui
 
 
     ImVec2 WidgetWithResizeHandle(
+        const char* id,
         VoidFunction widgetGuiFunction,
         float handleSizeEm,
         std::optional<VoidFunction> onItemResized,
@@ -47,14 +48,15 @@ namespace HelloImGui
     {
         widgetGuiFunction();
 
+        ImGuiID widget_id = ImGui::GetID(id);
+        ImVec2 widget_size = ImGui::GetItemRectSize();
+
         if (ImGui::IsMouseHoveringRect(ImGui::GetItemRectMin(), ImGui::GetItemRectMax()))
         {
             if (onItemHovered.has_value() && onItemHovered)
                 onItemHovered.value()();
         }
 
-        ImVec2 widget_size = ImGui::GetItemRectSize();
-        ImGuiID widget_id = ImGui::GetItemID();
 
         float em = ImGui::GetFontSize(), size = em * handleSizeEm;
         ImVec2 widget_bottom_right = ImGui::GetItemRectMax();
@@ -72,6 +74,9 @@ namespace HelloImGui
         resizingState->MouseInResizingZone = ImGui::IsMouseHoveringRect(zone.Min, zone.Max);
         resizingState->MouseDown = ImGui::IsMouseDown(0);
 
+        bool wasMouseJustClicked = !previousResizingState.MouseDown && resizingState->MouseDown;
+        bool mouseInZoneBeforeAfter = previousResizingState.MouseInResizingZone && resizingState->MouseInResizingZone;
+
         ImVec2 mouseDelta = resizingState->MousePosition - previousResizingState.MousePosition;
 
         // Color
@@ -85,8 +90,6 @@ namespace HelloImGui
 
         if (!resizingState->Resizing)
         {
-            bool wasMouseJustClicked = !previousResizingState.MouseDown && resizingState->MouseDown;
-            bool mouseInZoneBeforeAfter = previousResizingState.MouseInResizingZone && resizingState->MouseInResizingZone;
             if (wasMouseJustClicked && mouseInZoneBeforeAfter)
             {
                 if (onItemResized.has_value() && onItemResized)