Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new CustomBackground callback #72

Merged
merged 3 commits into from
Nov 27, 2023
Merged

new CustomBackground callback #72

merged 3 commits into from
Nov 27, 2023

Conversation

wkjarosz
Copy link
Contributor

fixes #70

I wasn't sure whether the markdown documentation is autogenerated from the code comments, but, just in case, I included the documentation for the new callback both in the code and the markdown documentation.

Also, I moved the Impl_Frame_3D_ClearColor() (or CustomBackground) call to be just before RenderGui in CreateFramesAndRender(). Otherwise the Gui is delayed by 1 frame compared to the background.

@pthom pthom merged commit c5121ed into pthom:master Nov 27, 2023
16 of 17 checks passed
@pthom
Copy link
Owner

pthom commented Nov 27, 2023

Hello,

Thanks a lot for your contribution! It was perfect, so I merged it.

I wasn't sure whether the markdown documentation is autogenerated from the code comments

Yes, it is. See tools/doc/process_md_docs.py. It is called automatically if you invoke cmake with -DHELLOIMGUI_BUILD_DOCS=ON

Since it was worthy of a demo + documentation I added a demo: see a7afb9e

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom drawing behind GUI not possible due to Impl_Frame_3D_ClearColor()
2 participants