Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language section added to home page #422

Merged
merged 9 commits into from
Mar 11, 2021
Merged

Language section added to home page #422

merged 9 commits into from
Mar 11, 2021

Conversation

YogeshSharma01
Copy link
Contributor

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@YogeshSharma01
Copy link
Contributor Author

Hi, @govindgoel Please review.

@YogeshSharma01 YogeshSharma01 mentioned this pull request Jan 16, 2021
Open
govindgoel
govindgoel reviewed Jan 20, 2021
View reviewed changes
index.html Show resolved Hide resolved
@YogeshSharma01 YogeshSharma01 force-pushed the language-section-added-to-home-page branch from 1744f0c to 2b16183 Compare January 23, 2021 20:47
@YogeshSharma01
Copy link
Contributor Author

Hi, @govindgoel I have squashed the commits. Please merge the PR.

@jywarren
Copy link
Member

Hi, thanks for your help! can you connect us to the issue this is addressing? And, would you be able to share a screenshot? Thanks a lot!!!

@govindgoel
Copy link
Member

@jywarren closes #337 This is an enhancement feature, I think this will surely help.

@YogeshSharma01
Copy link
Contributor Author

Hi, @jywarren this is an enhancement feature as @govindgoel mentioned.

Lang.mov

@YogeshSharma01 YogeshSharma01 force-pushed the language-section-added-to-home-page branch from 1153405 to cc4ae48 Compare February 20, 2021 07:45
@YogeshSharma01
Copy link
Contributor Author

Language-section.mov

daemon1024
daemon1024 reviewed Feb 26, 2021
View reviewed changes
index.html Outdated
@@ -21,6 +21,9 @@
<link rel="manifest" href="./manifest.json">
<script src="./src/scripts/pwainit.js"></script>


<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was it needed to fetch from CDN? Don't we already have it as a dependency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed
Thanks

@YogeshSharma01 YogeshSharma01 force-pushed the language-section-added-to-home-page branch from 16263eb to 681419e Compare February 27, 2021 06:25
jywarren
jywarren reviewed Feb 27, 2021
View reviewed changes
examples/demo.js Outdated Show resolved Hide resolved
@YogeshSharma01 YogeshSharma01 force-pushed the language-section-added-to-home-page branch from 4eafc67 to 9ac4641 Compare March 2, 2021 10:16
@YogeshSharma01
Copy link
Contributor Author

Hi, @jywarren we are using Bootstrap 3.4.0 in our project which uses only a default color which is grey. The changes I've done are with this version only.
If we need to change its color, then either we upgrade to 4.0 or manually set it.
Though I think that this color is suitable as per the website. What do you say?

Badge-Language_Section.mov

@jywarren
Copy link
Member

jywarren commented Mar 2, 2021

I think this looks great. The only and hopefully final change I'd ask is that we filter out null values, is that ok? Thank you so much!

jywarren
jywarren reviewed Mar 2, 2021
View reviewed changes
index.html Outdated
@@ -191,6 +245,14 @@ <h3>3.<br />Create a welcoming issue for someone else</h3>
</div>

<br />
<!-- Langauge section -->
<h2><span id="fto-issue">Languages</span> Uses</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h2><span id="fto-issue">Languages</span> Uses</h2>
<h2><span id="fto-issue">Languages</span> Used</h2>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@YogeshSharma01 YogeshSharma01 force-pushed the language-section-added-to-home-page branch from e44e8c3 to 9ac4641 Compare March 2, 2021 18:47
@YogeshSharma01
Copy link
Contributor Author

Hi, @jywarren, in case if null, should we not add a label to the repo or some text instead? Like - NA

@jywarren
Copy link
Member

jywarren commented Mar 4, 2021 via email

@YogeshSharma01 YogeshSharma01 force-pushed the language-section-added-to-home-page branch from ef8dfba to 0851399 Compare March 4, 2021 17:14
@YogeshSharma01
Copy link
Contributor Author

Hi, @jywarren all set, and thanks

Language-test.mov

Please Review

@jywarren
Copy link
Member

jywarren commented Mar 5, 2021

Oh, I'm sorry -- would it also be possible to move the listings to the bottom of the page? Perhaps just above "Stale Issues" or below Contributors? Thank you, I'm sorry i thought I'd made that suggestion already. Many thanks!

@YogeshSharma01
Copy link
Contributor Author

YogeshSharma01 commented Mar 6, 2021 via email

@YogeshSharma01
Copy link
Contributor Author

YogeshSharma01 commented Mar 6, 2021 via email

@YogeshSharma01 YogeshSharma01 force-pushed the language-section-added-to-home-page branch from 792ce72 to 1dc453a Compare March 7, 2021 06:54
@YogeshSharma01
Copy link
Contributor Author

Hi, @jywarren I have set the language section just below the contributor's section.

Language-final.mov

@jywarren jywarren closed this Mar 8, 2021
@jywarren jywarren reopened this Mar 8, 2021
@jywarren
Copy link
Member

jywarren commented Mar 8, 2021

Hi! Great. Restarting the checks to try to get gitpod to pass. Thanks!!

@YogeshSharma01
Copy link
Contributor Author

Hi! Great. Restarting the checks to try to get gitpod to pass. Thanks!!

Yeah Sure.

@jywarren
Copy link
Member

jywarren commented Mar 9, 2021

Hm, i'm so sorry, this is seeming to get stuck. Would you mind rebasing it and/or adding one more commit to see if we can get GitPod to go? Otherwise I can turn off the GitPod requirement as maybe I have it misconfigured. Apologies for the trouble!

@YogeshSharma01 YogeshSharma01 force-pushed the language-section-added-to-home-page branch from 0b652c9 to 1dc453a Compare March 9, 2021 18:42
@YogeshSharma01
Copy link
Contributor Author

YogeshSharma01 commented Mar 9, 2021 •
edited
Loading

Hi, @jywarren I think it would be stuck again with this gitpod.

@govindgoel
Copy link
Member

govindgoel commented Mar 10, 2021 •
edited
Loading

@YogeshSharma01 it's strange that Gitpod is getting stuck can you try once with squashing all the commits then run it again.

@YogeshSharma01
Copy link
Contributor Author

I don't think squashing all the commits would work @jywarren what do you think? should I squashing all the commits and try again?

@jywarren
Copy link
Member

Oh that's OK - i'll just turn off the gitpod check. Thanks!!!

@jywarren jywarren closed this Mar 11, 2021
@jywarren jywarren reopened this Mar 11, 2021
@jywarren jywarren merged commit 2632379 into publiclab:main Mar 11, 2021
@jywarren
Copy link
Member

Great work! Awesome to finally see this wrapped up! Thanks for your patience and persistence!!!

@YogeshSharma01 YogeshSharma01 mentioned this pull request Mar 12, 2021
Merged
5 tasks
@YogeshSharma01 YogeshSharma01 mentioned this pull request Mar 21, 2021
Closed
TildaDares pushed a commit to TildaDares/community-toolbox that referenced this pull request Apr 28, 2021
@YogeshSharma01 @TildaDares
Language section added to home page (publiclab#422)
a48bb51 
* New Navbar added with the logo of PublicLab

* New language section added

* Fix the mobile view issue in Language section

* Fix the mobile view hover issue in Language section

* jQuery CDN removed

* Badge used in language section

* set the null values as N/A

* Set the language section below Contributors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@govindgoel govindgoel govindgoel left review comments

@daemon1024 daemon1024 daemon1024 left review comments

@jywarren jywarren jywarren left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YogeshSharma01 @jywarren @govindgoel @daemon1024