Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added changes specified in issue#10176 #10177

Closed

Conversation

ShehanAT
Copy link
Contributor

Added line: <%= raw translation('editor.rich.drag_image') %> to app/views/editor/rich.html.erb
and

rich:
  drag_image: "Drag an image here to upload."

to config/locales/en.yml

Fixes #10176 10176

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [ x] PR is descriptively titled 📑 and links the original issue above 🔗
  • [ x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • [ x] code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@ShehanAT ShehanAT requested a review from a team as a code owner September 20, 2021 01:30
@welcome
Copy link

welcome bot commented Sep 20, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented Sep 20, 2021

@codeclimate
Copy link

codeclimate bot commented Sep 20, 2021

Code Climate has analyzed commit f351cbb and detected 0 issues on this pull request.

View more on Code Climate.

@noi5e
Copy link
Contributor

noi5e commented Sep 20, 2021

Thank you @ShehanAT, unfortunately I was reserving this first-timer-only issue for another contributor.

I'm going to close this PR. If you want a first-timer issue please leave a comment at #10153.

@noi5e noi5e closed this Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Strings to Translation Function Call in rich.html.erb
2 participants