Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update admin_controller.rb #11437

Closed
wants to merge 1 commit into from

Conversation

abhishek0chauhan
Copy link

Fixes #0000

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@welcome
Copy link

welcome bot commented Sep 23, 2022

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@gitpod-io
Copy link

gitpod-io bot commented Sep 23, 2022

@codeclimate
Copy link

codeclimate bot commented Sep 23, 2022

Code Climate has analyzed commit 576cec8 and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 5

View more on Code Climate.

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #11437 (576cec8) into main (b9a12dd) will decrease coverage by 4.98%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11437      +/-   ##
==========================================
- Coverage   82.40%   77.42%   -4.99%     
==========================================
  Files          96       96              
  Lines        5946     6072     +126     
==========================================
- Hits         4900     4701     -199     
- Misses       1046     1371     +325     
Impacted Files Coverage Δ
app/controllers/admin_controller.rb 0.00% <0.00%> (-80.25%) ⬇️
app/jobs/digest_spam_job.rb 0.00% <0.00%> (-33.34%) ⬇️
app/models/user.rb 86.13% <0.00%> (-0.37%) ⬇️

@TildaDares
Copy link
Member

Hi @abhishek0chauhan, can you add a link to the issue?

One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the
format fixes #0000 (for example)

@TildaDares
Copy link
Member

Hi @abhishek0chauhan, please take a look at the issue reserved for you to know the changes required #11429. Thank you!

@TildaDares
Copy link
Member

Thank you for taking the time to work on this PR but the issue has been resolved in #11531.

@TildaDares TildaDares closed this Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants