Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README.md to include GNUPG2 installation for setup on Windows WSL #11465

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

RealRichi3
Copy link
Contributor

@RealRichi3 RealRichi3 commented Oct 10, 2022

Added sudo apt install gnupg2 to the project installation guide (README.md) for Windows subsystem for linux

Fixes #11464

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@welcome
Copy link

welcome bot commented Oct 10, 2022

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@gitpod-io
Copy link

gitpod-io bot commented Oct 10, 2022

@codeclimate
Copy link

codeclimate bot commented Oct 10, 2022

Code Climate has analyzed commit 6b1b724 and detected 0 issues on this pull request.

View more on Code Climate.

@RealRichi3 RealRichi3 changed the title Update README.md: Include GNUPG2 installation for project setup on WSL2 Update README.md: Included GNUPG2 installation for installation on Windows WSL Oct 10, 2022
@RealRichi3 RealRichi3 changed the title Update README.md: Included GNUPG2 installation for installation on Windows WSL Update README.md to include GNUPG2 installation for setup on Windows WSL Oct 10, 2022
@RealRichi3 RealRichi3 changed the title Update README.md to include GNUPG2 installation for setup on Windows WSL Updated README.md to include GNUPG2 installation for setup on Windows WSL Oct 10, 2022
@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8706943290/artifacts/393189494

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #11465 (6b1b724) into main (5d94500) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #11465   +/-   ##
=======================================
  Coverage   83.21%   83.21%           
=======================================
  Files          93       93           
  Lines        5772     5772           
=======================================
  Hits         4803     4803           
  Misses        969      969           
Impacted Files Coverage Δ
app/controllers/images_controller.rb 72.50% <100.00%> (ø)

@RealRichi3
Copy link
Contributor Author

@jywarren please review my request

@@ -135,6 +135,7 @@ Before continuing with the installation steps in this README, users of Windows S
* `sudo apt install libyaml-dev make pkg-config sqlite3 zlib1g-dev libgmp-dev`
* `sudo apt install libreadline-dev libssl-dev`
2. Add GPG Key & Install RVM:
* `sudo apt install gnupg2`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this @RealRichi3, its looking good. Maybe we should add some text before the command smth like "Install gnupg2 if you haven't already: " What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I'll add that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or better still, since I've already contributed, let me make it a first-time-issue so others can fix it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great 👍 . Thanks

@cesswairimu cesswairimu merged commit 21dfe4c into publiclab:main Oct 13, 2022
@welcome
Copy link

welcome bot commented Oct 13, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

You can also join our Gitter channel to connect with other contributors 📥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while adding GPG key for project installation in Windows subsystem for linux
2 participants