-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated README.md to include GNUPG2 installation for setup on Windows WSL #11465
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit 6b1b724 and detected 0 issues on this pull request. View more on Code Climate. |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #11465 +/- ##
=======================================
Coverage 83.21% 83.21%
=======================================
Files 93 93
Lines 5772 5772
=======================================
Hits 4803 4803
Misses 969 969
|
@jywarren please review my request |
@@ -135,6 +135,7 @@ Before continuing with the installation steps in this README, users of Windows S | |||
* `sudo apt install libyaml-dev make pkg-config sqlite3 zlib1g-dev libgmp-dev` | |||
* `sudo apt install libreadline-dev libssl-dev` | |||
2. Add GPG Key & Install RVM: | |||
* `sudo apt install gnupg2` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this @RealRichi3, its looking good. Maybe we should add some text before the command smth like "Install gnupg2 if you haven't already: " What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I'll add that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or better still, since I've already contributed, let me make it a first-time-issue
so others can fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great 👍 . Thanks
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. You can also join our Gitter channel to connect with other contributors 📥 |
Added
sudo apt install gnupg2
to the project installation guide (README.md) for Windows subsystem for linuxFixes #11464
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below