-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interpolate redirect path- search-controller #11509
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit 23f0b48 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #11509 +/- ##
=======================================
Coverage 83.33% 83.33%
=======================================
Files 93 93
Lines 5772 5772
=======================================
Hits 4810 4810
Misses 962 962
|
@TildaDares Not exactly sure what is making the test fail. I've attached a screenshot of the error. |
Hi @HM-8, I’m not sure why the test is failing since you did everything right. Here’s the failing test:
I’ll restart the test and let’s see what happens then. |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
@TildaDares Okay great. I think all the tests have passed. How do I get this reviewed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @HM-8. Thank you!
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. You can also join our Gitter channel to connect with other contributors 📥 |
Congratulations on merging your PR @HM-8 🎉🎉 |
Fixes #11500
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below