[System Tests] Consolidate Comment Tests for Wikis, Questions, and Notes

[noi5e]

Instead of continuing to write distinct comment tests for wikis, questions, notes, etc. I decided to consolidate them.

The basic format of comment_test.rb is now:

page_types.each do |page_type, node_name|
    page_type_string = page_type.to_s

    test "#{page_type_string}: test title" do
        # do something
        # make assertion
    end
end

NOTES:

• Can you review test_helper.rb, and make sure that I'm implementing this block correctly?
• I went ahead and and put all 14 tests into the loop, which increases the # of tests to 42. (14 tests * 3 page types)
  • I can easily scale this back for comfort's sake, just let me know!
• I ran the tests locally and the runtime doesn't seem to have slowed down at all.
• The tests look fine, so I believe this is ready to merge.

(This PR is part of the larger Comment Editor Overhaul Project with Outreachy. Refer to Planning Issue #9069 for more context)

[gitpod-io]

[noi5e]

Rebased to match the new and improved master!

[jywarren]

Hmm, it seems stalled? I'll try restarting it. Thanks!

[gitpod-io]

[jywarren]

Hmm... That's odd. If it doesn't start soon, could you try a manual rebase with git rebase... instead of the merge? Maybe that'll trigger it. Sorry, thought it'd be more straightforward!

[jywarren]

OK, we modified the trigger to be for pull_request instead and hopefully it'll trigger properly now given one more rebase. My apologies for getting that trigger wrong!

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (main@98c561e). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8860   +/-   ##
=======================================
  Coverage        ?   81.86%           
=======================================
  Files           ?      100           
  Lines           ?     5938           
  Branches        ?        0           
=======================================
  Hits            ?     4861           
  Misses          ?     1077           
  Partials        ?        0           

[codeclimate]

Code Climate has analyzed commit a2bd219 and detected 0 issues on this pull request.

View more on Code Climate.

[jywarren]

I think this is unrelated to our code, but it's probably worth opening a new issue for it and trying to search for this issue in relation to github actions, or maybe in the mysql github action:

/home/runner/work/plots2/plots2/vendor/bundle/ruby/2.6.0/gems/ffi-1.13.1/lib/ffi/library.rb:112: [BUG] Illegal instruction at 0x00007fb387d3a6d0
ruby 2.6.6p146 (2020-03-31 revision 67876) [x86_64-linux]

-- Control frame information -----------------------------------------------
c:0057 p:---- s:0287 e:000286 CFUNC  :open
c:0056 p:0022 s:0281 e:000280 BLOCK  /home/runner/work/plots2/plots2/vendor/bundle/ruby/2.6.0/gems/ffi-1.13.1/lib/ffi/library.rb:112 [FINISH]
c:0055 p:---- s:0272 e:000271 CFUNC  :each
c:0054 p:0113 s:0268 e:000267 BLOCK  /home/runner/work/plots2/plots2/vendor/bundle/ruby/2.6.0/gems/ffi-1.13.1/lib/ffi/library.rb:109 [FINISH]

in the meantime i restarted!

[jywarren]

Looks great!!

[jywarren]

Looks awesome. I'll merge it now!!!

[jywarren]

huh cool! I didn't know you could nest test blocks under a loop, but that makes sense as long as the names are unique! Great work!

[noi5e]

Thanks! 🎈 Creative solution, but it seems to work!

[jywarren]

Awesome! So great to see everything pass here! Thanks @noi5e !!!! 👍 🎉