Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $D.selected Comment Documentation, Change .bind eventHandlers to .on #8982

Merged
merged 2 commits into from
Jan 10, 2021

Conversation

noi5e
Copy link
Contributor

@noi5e noi5e commented Jan 9, 2021

This is followup for PR #8897, which fixed #8670 (edit/main image drag&drop cross-wiring).

  • changes some jQuery .bind eventHandlers to .on
    • in comments/_edit.html.erb, which Sagarpreet noticed here
    • also in comment.js
  • leave some comments explaining this commit: initialize $E with params in dragdrop.js

This PR is part of the larger Comment Editor Overhaul Project with Outreachy. Refer to Planning Issue #9069 for more context

@noi5e noi5e requested a review from a team as a code owner January 9, 2021 20:31
@gitpod-io
Copy link

gitpod-io bot commented Jan 9, 2021

@codeclimate
Copy link

codeclimate bot commented Jan 9, 2021

Code Climate has analyzed commit fe2c155 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jan 9, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@d38da1c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8982   +/-   ##
=======================================
  Coverage        ?   82.03%           
=======================================
  Files           ?      100           
  Lines           ?     5956           
  Branches        ?        0           
=======================================
  Hits            ?     4886           
  Misses          ?     1070           
  Partials        ?        0           

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!!!!

@jywarren jywarren merged commit 626c26c into publiclab:main Jan 10, 2021
@noi5e noi5e deleted the feature/edit-main-crosswiring-followup branch January 10, 2021 02:00
@noi5e noi5e changed the title Feature: Add $D.selected Comment Documentation, Change .bind eventHandlers to .on Add $D.selected Comment Documentation, Change .bind eventHandlers to .on Jan 23, 2021
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
…dlers to .on (publiclab#8982)

* change .bind eventHandlers to on publiclab#8897

* write explanatory comments publiclab#8897
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
…dlers to .on (publiclab#8982)

* change .bind eventHandlers to on publiclab#8897

* write explanatory comments publiclab#8897
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
…dlers to .on (publiclab#8982)

* change .bind eventHandlers to on publiclab#8897

* write explanatory comments publiclab#8897
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
…dlers to .on (publiclab#8982)

* change .bind eventHandlers to on publiclab#8897

* write explanatory comments publiclab#8897
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag and drop feature of comment editor does not work properly when editing a comment
2 participants