-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add $D.selected Comment Documentation, Change .bind eventHandlers to .on #8982
Merged
jywarren
merged 2 commits into
publiclab:main
from
noi5e:feature/edit-main-crosswiring-followup
Jan 10, 2021
Merged
Add $D.selected Comment Documentation, Change .bind eventHandlers to .on #8982
jywarren
merged 2 commits into
publiclab:main
from
noi5e:feature/edit-main-crosswiring-followup
Jan 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Climate has analyzed commit fe2c155 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #8982 +/- ##
=======================================
Coverage ? 82.03%
=======================================
Files ? 100
Lines ? 5956
Branches ? 0
=======================================
Hits ? 4886
Misses ? 1070
Partials ? 0 |
jywarren
approved these changes
Jan 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!!!!
noi5e
changed the title
Feature: Add $D.selected Comment Documentation, Change .bind eventHandlers to .on
Add $D.selected Comment Documentation, Change .bind eventHandlers to .on
Jan 23, 2021
manchere
pushed a commit
to manchere/plots2
that referenced
this pull request
Feb 13, 2021
…dlers to .on (publiclab#8982) * change .bind eventHandlers to on publiclab#8897 * write explanatory comments publiclab#8897
lagunasmel
pushed a commit
to lagunasmel/plots2
that referenced
this pull request
Mar 2, 2021
…dlers to .on (publiclab#8982) * change .bind eventHandlers to on publiclab#8897 * write explanatory comments publiclab#8897
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
…dlers to .on (publiclab#8982) * change .bind eventHandlers to on publiclab#8897 * write explanatory comments publiclab#8897
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
…dlers to .on (publiclab#8982) * change .bind eventHandlers to on publiclab#8897 * write explanatory comments publiclab#8897
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is followup for PR #8897, which fixed #8670 (edit/main image drag&drop cross-wiring).
This PR is part of the larger Comment Editor Overhaul Project with Outreachy. Refer to Planning Issue #9069 for more context