Add Unique Toolbar Button IDs #8995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #8995 +/- ##
=======================================
Coverage ? 82.05%
=======================================
Files ? 100
Lines ? 5962
Branches ? 0
=======================================
Hits ? 4892
Misses ? 1070
Partials ? 0 |
|
Code Climate has analyzed commit 7871ee7 and detected 0 issues on this pull request. View more on Code Climate. |
jywarren
approved these changes
Jan 12, 2021
| @@ -77,6 +77,20 @@ def get_large_dropzone_id(location, reply_to) | |||
| end | |||
| end | |||
|
|
|||
| # used in views/editor/_toolbar.html.erb | |||
There was a problem hiding this comment.
thanks for the comment here, these can be tough to trace! There is the ability to make view-specific helpers like editor_helper.rb but often if they only contain a few lines, it can make them harder to find!
| </div> | ||
|
|
||
| <div class="btn-group"> | ||
| <a aria-label="Help" data-toggle="tooltip" title="Help" data-placement="bottom" class="btn btn-outline-secondary btn-sm" target="_blank" href="/wiki/authoring-help"><i class="fa fa-question-circle" ></i></a> | ||
| <a | ||
| id="help-button-<%= toolbar_element_id %>" |
There was a problem hiding this comment.
appreciate the formatting work here. Thanks!
|
Awesome, thanks!!! |
noi5e
changed the title
manchere
pushed a commit
to manchere/plots2
that referenced
this pull request
Feb 13, 2021
* add logic for editor/toolbar partial publiclab#8478 * add unique toolbar button IDs publiclab#8478 * remove trailing whitespaces
lagunasmel
pushed a commit
to lagunasmel/plots2
that referenced
this pull request
Mar 2, 2021
* add logic for editor/toolbar partial publiclab#8478 * add unique toolbar button IDs publiclab#8478 * remove trailing whitespaces
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
* add logic for editor/toolbar partial publiclab#8478 * add unique toolbar button IDs publiclab#8478 * remove trailing whitespaces
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
* add logic for editor/toolbar partial publiclab#8478 * add unique toolbar button IDs publiclab#8478 * remove trailing whitespaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #8478
I think this will be relatively simple to review 🤞
Adding unique IDs and common classes to the toolbar buttons used in comment forms.
My eventual goal is to assign click eventHandlers to each button. Having unique IDs will ensure that
e.targetwill be accurate, as we've seen with bug fixes for image upload cross-wiring.(This issue is part of the larger Comment Editor Overhaul Project with Outreachy. Refer to Planning Issue #9069 for more context)