Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tooltips to Fresh Comments #9198

Merged
merged 5 commits into from
Feb 16, 2021

Conversation

noi5e
Copy link
Contributor

@noi5e noi5e commented Feb 14, 2021

I noticed that hover tooltips weren't showing for fresh comments. Made some slight tweaks in the views so this would happen.

Also adjusted the padding for comments... The padding has seemed a little too narrow lately and I remember it being a bit wider.

Before:
Screen Shot 2021-02-14 at 1 39 39 PM

After:
Screen Shot 2021-02-14 at 1 34 27 PM


(This issue is part of the larger Comment Editor Overhaul Project with Outreachy. Refer to Planning Issue #9069 for more context)

@gitpod-io
Copy link

gitpod-io bot commented Feb 14, 2021

@codecov
Copy link

codecov bot commented Feb 14, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@6ec8308). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9198   +/-   ##
=======================================
  Coverage        ?   50.11%           
=======================================
  Files           ?      100           
  Lines           ?     6134           
  Branches        ?        0           
=======================================
  Hits            ?     3074           
  Misses          ?     3060           
  Partials        ?        0           

@noi5e noi5e force-pushed the add-tooltips-to-fresh-comments branch from fce8957 to 15794f9 Compare February 15, 2021 21:03
@codeclimate
Copy link

codeclimate bot commented Feb 15, 2021

Code Climate has analyzed commit 4ed1839 and detected 0 issues on this pull request.

View more on Code Climate.

@noi5e
Copy link
Contributor Author

noi5e commented Feb 15, 2021

Yeah, I did a git rebase!!! Also, this is ready to merge now!

@jywarren jywarren merged commit ebf57e0 into publiclab:main Feb 16, 2021
@jywarren
Copy link
Member

Nice!!! 👍🏽

@noi5e noi5e deleted the add-tooltips-to-fresh-comments branch February 16, 2021 18:08
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
* git rebase

* better label sizing for cyto (publiclab#9189)

* adjust padding on comments

* add tooltips to freshly posted comments

* add hover tooltips to emoji reaction button

Co-authored-by: Jeffrey Warren <[email protected]>
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
* git rebase

* better label sizing for cyto (publiclab#9189)

* adjust padding on comments

* add tooltips to freshly posted comments

* add hover tooltips to emoji reaction button

Co-authored-by: Jeffrey Warren <[email protected]>
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* git rebase

* better label sizing for cyto (publiclab#9189)

* adjust padding on comments

* add tooltips to freshly posted comments

* add hover tooltips to emoji reaction button

Co-authored-by: Jeffrey Warren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants