-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tooltips to Fresh Comments #9198
Merged
jywarren
merged 5 commits into
publiclab:main
from
noi5e:add-tooltips-to-fresh-comments
Feb 16, 2021
Merged
Add Tooltips to Fresh Comments #9198
jywarren
merged 5 commits into
publiclab:main
from
noi5e:add-tooltips-to-fresh-comments
Feb 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #9198 +/- ##
=======================================
Coverage ? 50.11%
=======================================
Files ? 100
Lines ? 6134
Branches ? 0
=======================================
Hits ? 3074
Misses ? 3060
Partials ? 0 |
noi5e
force-pushed
the
add-tooltips-to-fresh-comments
branch
from
February 15, 2021 21:03
fce8957
to
15794f9
Compare
Code Climate has analyzed commit 4ed1839 and detected 0 issues on this pull request. View more on Code Climate. |
Yeah, I did a |
jywarren
approved these changes
Feb 16, 2021
Nice!!! 👍🏽 |
lagunasmel
pushed a commit
to lagunasmel/plots2
that referenced
this pull request
Mar 2, 2021
* git rebase * better label sizing for cyto (publiclab#9189) * adjust padding on comments * add tooltips to freshly posted comments * add hover tooltips to emoji reaction button Co-authored-by: Jeffrey Warren <[email protected]>
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
* git rebase * better label sizing for cyto (publiclab#9189) * adjust padding on comments * add tooltips to freshly posted comments * add hover tooltips to emoji reaction button Co-authored-by: Jeffrey Warren <[email protected]>
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
* git rebase * better label sizing for cyto (publiclab#9189) * adjust padding on comments * add tooltips to freshly posted comments * add hover tooltips to emoji reaction button Co-authored-by: Jeffrey Warren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that hover tooltips weren't showing for fresh comments. Made some slight tweaks in the views so this would happen.
Also adjusted the padding for comments... The padding has seemed a little too narrow lately and I remember it being a bit wider.
Before:
After:
(This issue is part of the larger Comment Editor Overhaul Project with Outreachy. Refer to Planning Issue #9069 for more context)