Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide first-time or spam replied-comments #9381

Merged
merged 2 commits into from
Mar 30, 2021

Conversation

17sushmita
Copy link
Member

Fixes #8854

  • Hide spam or first time replies to comments
  • Added tests to confirm the if the spam or first-time replied comment is visible to different group of users or not.
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • ask @publiclab/reviewers for help, in a comment below

@17sushmita 17sushmita requested a review from a team as a code owner March 27, 2021 17:17
@gitpod-io
Copy link

gitpod-io bot commented Mar 27, 2021

@codeclimate
Copy link

codeclimate bot commented Mar 27, 2021

Analysis results are not available for those commits

View more on Code Climate.

@cesswairimu
Copy link
Collaborator

restarting build

@cesswairimu cesswairimu reopened this Mar 27, 2021
@gitpod-io
Copy link

gitpod-io bot commented Mar 27, 2021

@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@07a243d). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 5519dae differs from pull request most recent head 01c9d0f. Consider uploading reports for the commit 01c9d0f to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9381   +/-   ##
=======================================
  Coverage        ?   49.67%           
=======================================
  Files           ?       98           
  Lines           ?     6110           
  Branches        ?        0           
=======================================
  Hits            ?     3035           
  Misses          ?     3075           
  Partials        ?        0           

@@ -491,6 +491,92 @@ def get_path(page_type, path)
assert_selector("#{edit_preview_id} img", count: 1)
end

test "#{page_type_string}: should list first time replied comment to moderator" do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gosh this is fantastic!!! Thank you and great work!!!

@jywarren jywarren merged commit 9ba8f6d into publiclab:main Mar 30, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
* Hide replied comments which are spam or first time comment

* Added replied comment moderation tests
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* Hide replied comments which are spam or first time comment

* Added replied comment moderation tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide replies to comments that have been spammed or aren't yet moderated
3 participants