Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: gTLD autopull updates for 2023-08-02T15:11:59 UTC #1816

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 2, 2023

Public suffix list gTLD data updates from tools/patchnewgtlds for 2023-08-02T15:11:59 UTC.

@weppos weppos requested review from weppos and dnsguru August 2, 2023 15:37
Copy link
Member

@weppos weppos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnsguru this is the first run after #1812. It's somehow expected to have such a large change set.

I went through the changes and I did not spot anything incorrect. It's good to go for me. I'm waiting also your 👍

@weppos weppos assigned weppos and unassigned dnsguru Aug 2, 2023
@dnsguru
Copy link
Member

dnsguru commented Aug 2, 2023

Reviewing

@dnsguru dnsguru added ✅ autopull Automation pull from Authoritative ICANN json source 🚩ICANN (IANA/ICP-3) Section PR changes in the ICANN/IANA section typically reserved for TLDs. labels Aug 2, 2023
@dnsguru
Copy link
Member

dnsguru commented Aug 2, 2023

@weppos I re-opened and made some comments in #1806 that I think represent a better end-state for this - as we approach the next wave of nTLD applications, my bias is towards something that will be more consistent with the rest of the PSL and the guidelines in swapping in the IANA URL per nTLD on another comment line as we remove the date.

@dnsguru
Copy link
Member

dnsguru commented Aug 3, 2023

Will merge this.

Would like to get #1815 merged but it may need someone more famiar with the actions yml to test / approve

Copy link
Member

@dnsguru dnsguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tests Pass
  • Trusted Source ICANN JSON
  • No Conflict With Base
  • Automation

APPROVED

Comment:

Major change - but looks correct.
We modified the output of autopull to eliminate contract dates, which makes all the ntld entries diff.

We will be adding a comment line that adds another line with a link to the iana db entry for the TLD.

@dnsguru dnsguru merged commit 63cbc63 into master Aug 3, 2023
@dnsguru dnsguru deleted the psl-gtld-update branch August 3, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ autopull Automation pull from Authoritative ICANN json source 🚩ICANN (IANA/ICP-3) Section PR changes in the ICANN/IANA section typically reserved for TLDs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants