Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the order of flags in github actions workflows. #1906

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Change the order of flags in github actions workflows. #1906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
go-version: 'stable'

- name: Run Go unit tests
run: go test -C ./tools .
run: go test -C ./tools -v .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, any reason to not have:

Suggested change
run: go test -C ./tools -v .
run: cd ./tools && go test -v ./...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of chaining a cd, what about using the working-directory job config element?

Copy link
Contributor Author

@aaomidi aaomidi Nov 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion on how this is done. Up to maintainers to decide this.
I do have a preference for using the tools that Go has built in to the toolchain.

My main opinion is this is currently breaking the pipeline, so either we rollback #1901, or we accept this as is and revisit it if the need arises?


- name: Install dependencies
run: sudo apt install -y autopoint
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tld-update.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
go-version: 'stable'

- name: Run unit tests
run: go test -v -C ./tools .
run: go test -C ./tools -v .

- name: Set current date
id: get-date
Expand Down