Merge pull request #300 from publishpress/feature/#298-PHP_Notice_Try…

…ing_to_access_array_offse feature/#298-PHP_Notice_Trying_to_access_array_offse
publishpress · Nov 16, 2021 · 47a6fde · 47a6fde
2 parents cd70df2 + 4786c5b
commit 47a6fde
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/orgSeries-setup.php b/orgSeries-setup.php
@@ -296,15 +296,15 @@ function add_settings($reset = false) {
 			update_option('org_series_options', $this->settings);
 			return true;
 		}
-		if ( !defined('SERIES_QUERYVAR') ){
+		if ( is_array($this->settings) &&  !defined('SERIES_QUERYVAR') ){
 			define('SERIES_QUERYVAR', $this->settings['series_custom_base'] );  // get/post variable name for querying series from WP
         }
 
-        if(!isset($this->settings['series_table_of_contents_box_template'])){// this need to move to upgrade function
+        if(is_array($this->settings) && !isset($this->settings['series_table_of_contents_box_template'])){// this need to move to upgrade function
             $this->settings['series_table_of_contents_box_template'] = '<div class="serieslist-box"><div class="imgset">%series_icon_linked%</div><div class="serieslist-content"><h2>%series_title_linked%</h2><p>%series_description%</p></div><hr style="clear: left; border: none" /></div>';
         }
 
-        if(!isset($this->settings['series_taxonomy_slug'])){// this need to move to upgrade function
+        if(is_array($this->settings) && !isset($this->settings['series_taxonomy_slug'])){// this need to move to upgrade function
             $this->settings['series_taxonomy_slug'] = 'series';
         }
 

diff --git a/readme.txt b/readme.txt
@@ -142,6 +142,7 @@ v2.7.0- [===unreleased===]
 * Feature: Improve the "Series Table of Content" widge #238
 * Fixed: wp_serieslist_display() Not Working #287
 * Fixed: Issue with Seriously Simple Podcasting plugin #87
+* Fixed: PHP Notice: Trying to access array offse #298
 
 
 v2.6.3- 2021-09-29