Demiurge #4
Open
Demiurge #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use dynamic event allocation functions instead - Remove deprecated header file
- Also compile on Android, which lacks rand_r()
…afe in the face of other libevent usage in the same process
…ding when using libevent backend
If an HTTP call failed was retried due to the error retry settings, the HTTP callback data was freed when the first call failed, but the finished_cb_data held a dangling pointer onto that, so a crash occurred when the retry completed and that data was accessed and re-freed.
|
Thanks @demiawesson ! We're going to merge locally, wrap with tests, etc, please standby. |
|
Great. Let me know if everything works out. |
|
I applied some changes to this branch https://github.com/pubnub/c/tree/unsubscribe-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the changes we made to get pubnub up and running on windows with Visual Studio's compiler.
-Andrew