Fix subscribe request aggregation in SharedWorker.
#403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue because of which leave request modified wrong URL path component with actual channels. fix(shared-worker): fix channels / groups list modification issues Fix issue because of which removed channels / groups didn't cancel previous subscribe request to re-subscribe with new set of channels / groups. fix(shared-worker): fix requests aggregation issues Fix issue because of which suitable active PubNub clients subscription not has been used for aggregation and caused additional connections or wrong set of channels / groups. refactor(subscription): process messages only for subscribed Pre-process entries from subscribe response to filter out updates which has been received for channels and groups which are not part of subscription loop (subscription aggregation in shared worker). refactor(package): add `types` entry for Node.js integration Point to the built-in types definition file when package used with npm / yarn.
parfeon
added
status: done
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
techwritermat and
kazydek
as code owners
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(shared-worker): fix presence leave request preparation
Fix issue because of which leave request modified wrong URL path component with actual channels.
fix(shared-worker): fix channels / groups list modification issues
Fix issue because of which removed channels / groups didn't cancel previous subscribe request to re-subscribe with new set of channels / groups.
fix(shared-worker): fix requests aggregation issues
Fix issue because of which suitable active PubNub clients subscription not has been used for aggregation and caused additional connections or wrong set of channels / groups.
refactor(subscription): process messages only for subscribed
Pre-process entries from subscribe response to filter out updates which has been received for channels and groups which are not part of subscription loop (subscription aggregation in shared worker).
refactor(package): add
typesentry for Node.js integrationPoint to the built-in types definition file when package used with
npm/yarn.