Review feedback

pubnub · Jan 15, 2025 · ff8159e · ff8159e
1 parent 145ace4
commit ff8159e
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/src/jsMain/resources/index.d.ts b/src/jsMain/resources/index.d.ts
@@ -6,7 +6,7 @@ declare class Membership {
     private chat;
     readonly channel: Channel;
     readonly user: User;
-    readonly custom: AppContext.CustomData | null | undefined;
+    readonly custom?: AppContext.CustomData | null;
     readonly updated: string;
     readonly eTag: string;
     update({ custom }: {
@@ -247,14 +247,10 @@ type SendTextOptionParams = Omit<Publish.PublishParameters, "message" | "channel
     referencedChannels?: MessageReferencedChannels;
     textLinks?: TextLink[];
     quotedMessage?: Message;
-    files?: FileList | File[] | FileSharing.SendFileParameters<any>["file"][];
+    files?: FileList | File[] | FileSharing.SendFileParameters<PubNub.PubNubFileParameters>["file"][];
 };
-type EnhancedMessageEvent = Subscription.MessageEvent & {
-    userMetadata?: {
-        [key: string]: any;
-    };
-};
-type MessageDTOParams = History.FetchMessagesResponse["channels"]["channel"][0] | EnhancedMessageEvent;
+type EnhancedMessageEvent = Subscription.Message;
+type MessageDTOParams = History.FetchMessagesForChannelsResponse['channels'][string][number] | History.FetchMessagesWithActionsResponse['channels'][string][number] | EnhancedMessageEvent;
 type ThreadMessageDTOParams = MessageDTOParams & {
     parentChannelId: string;
 };
@@ -427,7 +423,7 @@ export declare class MessageDraftV2 {
     get value(): string;
     quotedMessage: Message | undefined;
     readonly config: MessageDraftConfig;
-    files?: FileList | File[] | FileSharing.SendFileParameters<any>["file"][];
+    files?: FileList | File[] | FileSharing.SendFileParameters<PubNub.PubNubFileParameters>["file"][];
     addQuote(message: Message): void;
     removeQuote(): void;
     addLinkedText(params: AddLinkedTextParams): void;
@@ -463,7 +459,7 @@ declare class MessageDraft {
     value: string;
     quotedMessage: Message | undefined;
     readonly config: MessageDraftConfig;
-    files?: FileList | File[] | FileSharing.SendFileParameters<any>["file"][];
+    files?: FileList | File[] | FileSharing.SendFileParameters<PubNub.PubNubFileParameters>["file"][];
     onChange(text: string): Promise<{
         users: {
             nameOccurrenceIndex: number;