Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fixture generation and add a zstd metadata fixture #244

Merged
merged 11 commits into from
Nov 16, 2023
Merged

Update fixture generation and add a zstd metadata fixture #244

merged 11 commits into from
Nov 16, 2023

Conversation

dralley
Copy link
Collaborator

@dralley dralley commented Nov 16, 2023 •
edited
Loading

Closes #245
Closes #242

@dralley dralley changed the title Update base container image, use createrepo_c instead of createrepo Update fixture generation and add a zstd metadata fixture Nov 16, 2023
@dralley dralley force-pushed the add-zstd-fixture branch 2 times, most recently from 9681bb5 to a2395b1 Compare November 16, 2023 00:58
@dralley dralley force-pushed the add-zstd-fixture branch 7 times, most recently from 78e42b7 to 7458607 Compare November 16, 2023 01:55
@dralley dralley requested a review from quba42 November 16, 2023 01:56
@dralley
Copy link
Collaborator Author

dralley commented Nov 16, 2023 •
edited
Loading

@quba42 Any idea why the Debian portion is failing to build? I assume this is the line: https://github.com/pulp/pulp-fixtures/actions/runs/6885272791/job/18729164889?pr=244#step:5:1941

I'm not sure if this has to do with swapping out the previous key though, because as far as I can tell I fixed it up in all the correct places?

Never mind, figured it out

@dralley dralley force-pushed the add-zstd-fixture branch 4 times, most recently from 9cbc1ca to 8f472d8 Compare November 16, 2023 04:06
@dralley dralley requested review from mdellweg and removed request for quba42 November 16, 2023 04:08
@dralley dralley force-pushed the add-zstd-fixture branch 6 times, most recently from 47980d5 to 6b57117 Compare November 16, 2023 06:18
mdellweg
mdellweg reviewed Nov 16, 2023
View reviewed changes
.github/workflows/issue_checker.yaml
@@ -5,13 +5,11 @@ jobs:
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

common/GPG-KEY-pulp-qe Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What called for this change?
I believe some CI is using the key directly from here. So changing it's name is probably a bad idea.
As is changing the key user-id.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key is ancient and uses algorithms that recent OS' consider legacy, and refuse to do anything with.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#245

Containerfile
Comment on lines +17 to +18
# the default createrepo_c provided by Fedora has legacy hashes disabled, the one
# on PyPI does not (because we need it)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if that package would be upgraded also? Want to add a version constraint?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah. It's actually good for something like that to make a bit of noise early on.

But also, the Python package is basically our responsibility in the first place, so it's unlikely to change out from under us.

@dralley
Swap old signing keys for new ones
20fbb57 
[noissue]
@dralley
Add an rpm repository with zstd-compressed metadata
e81cdf4 
[noissue]
@dralley
Set the default compression back to gzip
61c39f5 
createrepo_c 1.0 switched it to zstd

[noissue]
@dralley
Remove file signing option
016f280 
Seems like it only supports .pem format?

[noissue]
@dralley
Use createrepo_c from pypi
469cb1b 
The Fedora-packaged one no longer includes support for "legacy" hashes
like md5, sha1 whereas the version we've gotten packaged for ourselves
does.

[noissue]
@dralley
Disable zchunk fixture by default
85d0518 
We haven't gotten around to using it yet (and may never), RHEL doesn't
use zchunk and Fedora is on Zstd now, and the Python createrepo_c
version has it disabled for now.

[noissue]
@dralley
Remove Puppet fixtures
a648dfd 
[noissue]
@dralley dralley merged commit 30518d9 into master Nov 16, 2023
2 checks passed
@dralley dralley deleted the add-zstd-fixture branch November 16, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdellweg mdellweg mdellweg approved these changes

@dkliban dkliban dkliban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signed rpm fixtures can't be generated on Fedora 31+ zstd compressed RPM fixtures
3 participants
@dralley @dkliban @mdellweg