Add rpm-no-comps fixture #251
Conversation
|
@ggainey here is my attempt at the no-comps. Locally it looks correct. |
| @@ -523,6 +526,10 @@ fixtures/rpm-zstd-metadata: fixtures | |||
| rpm/gen-fixtures.sh $@ rpm/assets | |||
| createrepo_c --general-compress-type=zstd --update $@ | |||
|
|
|||
| fixtures/rpm-no-comps: fixtures | |||
There was a problem hiding this comment.
If you make fixtures/rpm-no-comps using this, you end up with a repo whose repomd.xml points-to the comps.xml that you then remove. This will cause a sync of that repo to fail. You need to call rpm/genfixtures.sh on a directory that doesn't have a comps.xml to begin with.
There was a problem hiding this comment.
That makes sense, the part about me breaking the repo with removing the comps.xml and the repomd.xml still pointing to it. The only 2 repos I found that didn't have a comps.xml was assets-modularity and assets-modular Would manually creating an assets directory from assets then updating the repomd.xml to not have any reference to comps.xml, remove the comps.xml then have the make file use that directory or is there a better way forward?
There was a problem hiding this comment.
The general pattern is, in the build-stanza in the Makefile for your fixture, you cp -r from assets into your chosen dir-name, remove comps.xml, and then gen-fixture the resulting directory.
[noissue]
|
@ggainey I think I got it figured out, looks right locally based on your feedback. Updated my commit message to have |
No description provided.