Add domain support #346
Merged
Add domain support #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hyagi
commented
Feb 8, 2024
| @@ -1,2 +1,2 @@ | |||
| pulpcore>=3.40.1,<3.55 | |||
| pulpcore>=3.45.1,<3.55 | |||
There was a problem hiding this comment.
Bumping minimum pulpcore version to 3.45.1 because our model depends on 0116_alter_remoteartifact_md5_alter_remoteartifact_sha1_and_more. Without it we get the error:
django.db.migrations.exceptions.NodeNotFoundError: Migration ostree.0008_add_domain_support dependencies reference nonexistent parent node ('core', '0116_alter_remoteartifact_md5_alter_remoteartifact_sha1_and_more')
lubosmj
reviewed
Feb 12, 2024
| @@ -98,7 +98,7 @@ if [ "$TEST" = "s3" ]; then | |||
| sed -i -e '$a s3_test: true\ | |||
| minio_access_key: "'$MINIO_ACCESS_KEY'"\ | |||
| minio_secret_key: "'$MINIO_SECRET_KEY'"\ | |||
| pulp_scenario_settings: null\ | |||
| pulp_scenario_settings: {"domain_enabled": true}\ | |||
There was a problem hiding this comment.
You should not manually edit this file. We want to update the plugin template configuration (pulp_settings_s3) and then re-generate the workflow scripts (by running /plugin-template --github pulp_ostree).
https://github.com/pulp/plugin_template/?tab=readme-ov-file#add-ci-configuration-to-a-pulp-plugin
There was a problem hiding this comment.
You still did not update the template configuration and did not run the plugin-template utility to re-generate the workflow scripts.
git-hyagi
force-pushed
the
add-domain-support
branch
from
d00911c to
b8b77fe
Compare
closes: pulp#321
git-hyagi
force-pushed
the
add-domain-support
branch
from
b8b77fe to
4296e74
Compare
lubosmj
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #321