Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the documentation to staging #355

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

lubosmj
Copy link
Member

@lubosmj lubosmj commented Feb 21, 2024

closes #347

@lubosmj lubosmj requested a review from pedro-psb February 21, 2024 11:41
Copy link
Member

@pedro-psb pedro-psb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content placement looks good to me!

The === "Script" syntax is mostly usefull for when there is more than one tab, its a little odd to use it with only one tab. I recommend removing these and using simple codeblocks in those cases:

# Single tabbed
- == "Script"
-
-    ```bash
-    pulp ostree repository sync --name foo --remote bar
-
-    ```

# Simple codeblocks
+```bash
+pulp ostree repository sync --name foo --remote bar
+```

@lubosmj lubosmj marked this pull request as draft February 21, 2024 13:14
@lubosmj lubosmj marked this pull request as ready for review February 21, 2024 14:21
@lubosmj lubosmj enabled auto-merge (rebase) February 21, 2024 14:22
@lubosmj lubosmj disabled auto-merge February 21, 2024 15:15
@lubosmj lubosmj merged commit 97184f5 into pulp:main Feb 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert pulp_ostree docs to new stack
2 participants