-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove drpm test and fix borked CI #3323
Conversation
bc923e3
to
1c4c128
Compare
1c4c128
to
cfaa4a6
Compare
@@ -870,7 +872,8 @@ def test_complete_mirror_with_delta_metadata_fails(init_and_sync): | |||
Otherwise we would be mirroring the metadata without mirroring the DRPM packages. | |||
""" | |||
with pytest.raises(PulpTaskError) as exc: | |||
init_and_sync(url=DRPM_UNSIGNED_FIXTURE_URL, sync_policy="mirror_complete") | |||
pass | |||
# init_and_sync(url=DRPM_UNSIGNED_FIXTURE_URL, sync_policy="mirror_complete") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove this commented out line instead?
you anyway deleted this from constants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intention is to bring it back in a mostly-identical form, does it make sense to delete the whole line? I'd rather it be obvious what this was doing before it was disabled.
Actually the only reason it's commented at all is because the constant was deleted, otherwise I'd just leave it intact but disabled.
54acea8
to
0a07ad7
Compare
ff075ee
to
19b3fd1
Compare
It's not worth maintaining the fixture, and in the future we ought to be able to do this test without it. [noissue]
870ece5
to
9c38f5b
Compare
bc0fa93
to
c2ef297
Compare
c2ef297
to
85a3bd3
Compare
We need to backport all of this, but of course patchback won't help us with multiple commits. @ipanova Should we squash and merge, or should I submit parts of this as independent PRs (like commit 3)? |
I'd squash it. Leave in the commit comment more info, i.e bullets on was done |
Backport to 3.18: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 392e74b on top of patchback/backports/3.18/392e74be907a6b588b3ad02ecc47eea3258b0d94/pr-3323 Backporting merged PR #3323 into main
🤖 @patchback |
Backport to 3.19: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 392e74b on top of patchback/backports/3.19/392e74be907a6b588b3ad02ecc47eea3258b0d94/pr-3323 Backporting merged PR #3323 into main
🤖 @patchback |
Backport to 3.22: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 392e74b on top of patchback/backports/3.22/392e74be907a6b588b3ad02ecc47eea3258b0d94/pr-3323 Backporting merged PR #3323 into main
🤖 @patchback |
Backport to 3.23: 💚 backport PR created✅ Backport PR branch: Backported as #3337 🤖 @patchback |
* Skip test that uses DRPM fixture, for now. It's not worth maintaining the fixture, and in the future we ought to be able to do this test without it. * Made metadata downloading util agnostic to compression type * Ditch all usages of http_get and http_get_headers for requests * Fix CI after working directory adjustment in the template (cherry picked from commit 392e74b)
* Skip test that uses DRPM fixture, for now. It's not worth maintaining the fixture, and in the future we ought to be able to do this test without it. * Made metadata downloading util agnostic to compression type * Ditch all usages of http_get and http_get_headers for requests * Fix CI after working directory adjustment in the template (cherry picked from commit 392e74b) Co-authored-by: Daniel Alley <dalley@redhat.com>
* Skip test that uses DRPM fixture, for now. It's not worth maintaining the fixture, and in the future we ought to be able to do this test without it. * Made metadata downloading util agnostic to compression type * Ditch all usages of http_get and http_get_headers for requests * Fix CI after working directory adjustment in the template
* Skip test that uses DRPM fixture, for now. It's not worth maintaining the fixture, and in the future we ought to be able to do this test without it. * Made metadata downloading util agnostic to compression type * Ditch all usages of http_get and http_get_headers for requests * Fix CI after working directory adjustment in the template
* Skip test that uses DRPM fixture, for now. It's not worth maintaining the fixture, and in the future we ought to be able to do this test without it. * Made metadata downloading util agnostic to compression type * Ditch all usages of http_get and http_get_headers for requests * Fix CI after working directory adjustment in the template
* Skip test that uses DRPM fixture, for now. It's not worth maintaining the fixture, and in the future we ought to be able to do this test without it. * Made metadata downloading util agnostic to compression type * Ditch all usages of http_get and http_get_headers for requests * Fix CI after working directory adjustment in the template
Backport to 3.23: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 392e74b on top of patchback/backports/3.23/392e74be907a6b588b3ad02ecc47eea3258b0d94/pr-3323 Backporting merged PR #3323 into main
🤖 @patchback |
Backport to 3.24: 💚 backport PR created✅ Backport PR branch: Backported as #3363 🤖 @patchback |
* Skip test that uses DRPM fixture, for now. It's not worth maintaining the fixture, and in the future we ought to be able to do this test without it. * Made metadata downloading util agnostic to compression type * Ditch all usages of http_get and http_get_headers for requests * Fix CI after working directory adjustment in the template (cherry picked from commit 392e74b)
* Skip test that uses DRPM fixture, for now. It's not worth maintaining the fixture, and in the future we ought to be able to do this test without it. * Made metadata downloading util agnostic to compression type * Ditch all usages of http_get and http_get_headers for requests * Fix CI after working directory adjustment in the template (cherry picked from commit 392e74b)
No description provided.