✅ Add tests for pageActions I guess..?

pulse-browser · Feb 11, 2024 · 28da8a4 · 28da8a4
1 parent a685208
commit 28da8a4
Show file tree

Hide file tree

Showing 20 changed files with 2,365 additions and 123 deletions.
diff --git a/apps/content/src/browser/components/omnibox/PageAction.svelte b/apps/content/src/browser/components/omnibox/PageAction.svelte
@@ -113,6 +113,10 @@
 </script>
 
 <ToolbarButton
+  id={`page-action-icon--${pageAction.extensionId
+    .replace('@', '')
+    .replace('}', '')
+    .replace('{', '')}`}
   kind="page-icon"
   bind:button
   on:click={handleClick}
@@ -130,7 +134,14 @@
 </ToolbarButton>
 
 {#if pageAction.popupUrl}
-  <xul:panel bind:this={panel} class="popup"></xul:panel>
+  <xul:panel
+    id={`page-action-panel--${pageAction.extensionId
+      .replace('@', '')
+      .replace('}', '')
+      .replace('{', '')}`}
+    bind:this={panel}
+    class="popup"
+  ></xul:panel>
 {/if}
 
 <style>

diff --git a/apps/content/src/shared/components/ToolbarButton.svelte b/apps/content/src/shared/components/ToolbarButton.svelte
@@ -7,9 +7,11 @@
   export let button: HTMLButtonElement | undefined = undefined
   export let kind: 'toolbar' | 'page-icon' = 'toolbar'
   export let tooltip: string | undefined = undefined
+  export let id = ''
 </script>
 
 <button
+  {id}
   class={`toolbar__button toolbar__button--${kind}`}
   bind:this={button}
   on:click

diff --git a/apps/content/src/shared/customizableUI/helpers.ts b/apps/content/src/shared/customizableUI/helpers.ts
@@ -289,6 +289,5 @@ export const fromExportTypeStable = (component: ExportComponent) =>
   fromExportTypeStableInternal('root')(component, 0)
 
 export const customizableUIDynamicPref = dynamicStringPref((json) => {
-  console.log('test', json)
   return fromExportTypeStable(JSON.parse(json) as ExportComponent)
 })
diff --git a/apps/content/static/gtests.html b/apps/content/static/gtests.html
@@ -18,12 +18,7 @@ <h1>Test runner</h1>
 
       // @ts-check
       /// <reference types="@browser/link" />
-      console.log('start import')
-
-      console.log('import int')
-
-      console.log('call')
-      TestManager.call()
+      TestManager.report()
     </script>
   </body>
 </html>
diff --git a/apps/extensions/lib/ext-browser.json b/apps/extensions/lib/ext-browser.json
@@ -5,5 +5,10 @@
     "scopes": ["addon_parent"],
     "manifest": ["page_action"],
     "paths": [["pageAction"]]
+  },
+  "tabs": {
+    "schema": "chrome://bextensions/content/schemas/tabs.json",
+    "scopes": ["addon_parent"],
+    "paths": [["tabs"]]
   }
 }
diff --git a/apps/extensions/lib/parent/ext-pageAction.js b/apps/extensions/lib/parent/ext-pageAction.js
@@ -15,6 +15,7 @@ this.pageAction = class extends ExtensionAPIPersistent {
     const options = extension.manifest.page_action
 
     this.pageAction = new lazy.EPageActions.PageAction({
+      extensionId: extension.id,
       tooltip: options.default_title,
       popupUrl: options.default_popup,
       showMatches: options.show_matches,
@@ -67,9 +68,7 @@ this.pageAction = class extends ExtensionAPIPersistent {
      */
     onClicked({ fire }) {
       const callback = async (_name, clickInfo) => {
-        console.log(fire, fire.wakeup, !!fire.wakeup)
         if (fire.wakeup) await fire.wakeup()
-        console.log('fire')
         fire.sync(clickInfo)
       }
 

diff --git a/apps/extensions/lib/parent/ext-tabs.js b/apps/extensions/lib/parent/ext-tabs.js
@@ -0,0 +1,9 @@
+// @ts-check
+/// <reference path="../types/index.d.ts" />
+
+this.tabs = class extends ExtensionAPIPersistent {
+  /**
+   * @param {BaseContext} context
+   */
+  getAPI(context) {}
+}