✨ Extension test support (#56)

Ports over the changes from #55. Primarily for integration testing.

## Added
- Window arguments (used for specifying browser urls)
- Infra for creating tests extensions

## Changed
- Use our own tap reporter with a less buggy parser

apps/content/src/browser/browser.js

@@ -4,8 +4,26 @@
 // @ts-check
 import BrowserWindow from './BrowserWindow.svelte'
 import './browser.css'
+import * as WindowTabs from './windowApi/WindowTabs.js'
 import { registerEventBus } from './windowApi/eventBus.js'
 
+// Handle window arguments
+let rawArgs = window.arguments && window.arguments[0]
+/** @type {Record<string, string>} */
+let args = {}
+
+if (rawArgs && rawArgs instanceof Ci.nsISupports) {
+  args = rawArgs.wrappedJSObject || {}
+} else if (rawArgs) {
+  args = rawArgs
+}
+
+const initialUrls = args.initialUrl
+  ? [args.initialUrl]
+  : ['https://google.com/', 'https://svelte.dev/']
+
+WindowTabs.initialize(initialUrls)
+
 registerEventBus()
 
 new BrowserWindow({ target: document.body })

apps/content/src/browser/components/PageAction.svelte

@@ -12,9 +12,15 @@
 
   /** @type {import('resource://app/modules/EPageActions.sys.mjs').PageActionImpl} */
   export let pageAction
+  /** @type {number} */
+  export let browserViewId
 
   const view = PageActionApi.setup(pageAction)
   const icons = PageActionApi.getIcons(view)
+  const extensionId = pageAction.extensionId
+    .replace('@', '')
+    .replace('}', '')
+    .replace('{', '')
   const trigger = view.trigger
   const panel = view.panel
 
@@ -45,7 +51,11 @@
   })
 </script>
 
-<UrlBoxButton bind:button={$trigger} on:click={PageActionApi.handleClick(view)}>
+<UrlBoxButton
+  bind:button={$trigger}
+  on:click={PageActionApi.handleClick(view)}
+  id={`page-action-icon__${extensionId}--${browserViewId}`}
+>
   {#if $icons}
     <img src={getIconUrlForPreferredSize($icons, 16)} />
   {:else}
@@ -54,7 +64,11 @@
 </UrlBoxButton>
 
 {#if pageAction.popupUrl}
-  <xul:panel bind:this={$panel} class="popup"></xul:panel>
+  <xul:panel
+    bind:this={$panel}
+    class="popup"
+    id={`page-action-panel__${extensionId}--${browserViewId}`}
+  ></xul:panel>
 {/if}
 
 <style>

apps/content/src/browser/components/UrlBox.svelte

@@ -162,7 +162,9 @@
   />
 
   {#each $pageActions as [_, pageAction]}
-    <PageAction {pageAction} />
+    {#if $uri && pageAction.shouldShow($uri.asciiSpec, view.browserId || 0)}
+      <PageAction {pageAction} browserViewId={view.windowBrowserId} />
+    {/if}
   {/each}
 
   <div

apps/content/src/browser/components/UrlBoxButton.svelte

@@ -4,11 +4,13 @@
 
 <script>
   export let disabled = false
+  /** @type {string | undefined} */
+  export let id = undefined
   /** @type {HTMLButtonElement | undefined} */
   export let button = undefined
 </script>
 
-<button on:click bind:this={button} {disabled}>
+<button on:click bind:this={button} {disabled} {id}>
   <slot />
 </button>
 

apps/content/src/browser/components/pageAction.js

@@ -66,12 +66,13 @@ export function handleClick(view) {
       },
     })
 
-    await buildPanelBrowser(view)
     // Panel may not exist if there is no popupUrl
     const panel = view.panel()
     if (view.panel()) {
       panel.openPopup(view.trigger(), 'bottomright topright')
     }
+
+    await buildPanelBrowser(view)
   }
 }
 

apps/content/src/browser/windowApi/WindowTabs.js

@@ -55,25 +55,23 @@ activeTabId.subscribe((activeId) => {
 /**
  * @type {import('@amadeus-it-group/tansu').WritableSignal<WebsiteTab[]>}
  */
-export const windowTabs = writable([
-  {
-    kind: 'website',
-    view: WebsiteViewApi.create(
-      browserImports.NetUtil.newURI('https://google.com'),
-    ),
-  },
-  {
-    kind: 'website',
-    view: WebsiteViewApi.create(
-      browserImports.NetUtil.newURI('https://svelte.dev'),
-    ),
-  },
-])
+export const windowTabs = writable([])
 
 export const activeTab = derived(
   [activeTabId, windowTabs],
   ([$activeTabId, $windowTabs]) =>
     $windowTabs.find((tab) => tab.view.windowBrowserId === $activeTabId),
 )
 
-activeTabId.set(windowTabs()[0].view.windowBrowserId)
+/**
+ * @param {string[]} urls
+ */
+export function initialize(urls) {
+  windowTabs.set(
+    urls.map((url) => ({
+      kind: 'website',
+      view: WebsiteViewApi.create(browserImports.NetUtil.newURI(url)),
+    })),
+  )
+  activeTabId.set(windowTabs()[0].view.windowBrowserId)
+}

apps/content/static/gtests.html

@@ -18,12 +18,7 @@ <h1>Test runner</h1>
 
       // @ts-check
       /// <reference types="@browser/link" />
-      console.log('start import')
-
-      console.log('import int')
-
-      console.log('call')
-      TestManager.call()
+      TestManager.report()
     </script>
   </body>
 </html>

apps/extensions/lib/parent/ext-pageAction.js

@@ -15,6 +15,7 @@ this.pageAction = class extends ExtensionAPIPersistent {
     const options = extension.manifest.page_action
 
     this.pageAction = new lazy.EPageActions.PageAction({
+      extensionId: extension.id,
       tooltip: options.default_title,
       popupUrl: options.default_popup,
       showMatches: options.show_matches,

apps/modules/lib/EPageActions.sys.mjs

@@ -1,7 +1,6 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-
 /// @ts-check
 /// <reference types="@browser/link" />
 import mitt from 'resource://app/modules/mitt.sys.mjs'
@@ -15,6 +14,7 @@ export class PageAction {
   /** @type {import('resource://app/modules/EPageActions.sys.mjs').PageActionImpl['events']} */
   events = mitt()
 
+  extensionId
   tooltip
   popupUrl
   showMatches
@@ -31,6 +31,7 @@ export class PageAction {
    * @param {import('resource://app/modules/EPageActions.sys.mjs').PageActionOptions<string[]>} data
    */
   constructor(data) {
+    this.extensionId = data.extensionId
     this.tooltip = data.tooltip
     this.popupUrl = data.popupUrl
     this.showMatches = new MatchPatternSet(data.showMatches || [])