🚨 Reduce the number of linter warnings

pulse-browser · Nov 18, 2023 · c85296f · c85296f
1 parent 37aca87
commit c85296f
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 8 deletions.
diff --git a/scripts/unit-test.ts b/scripts/unit-test.ts
@@ -17,6 +17,7 @@ new App()
   .get('/config', (_, res) => void res.send({ shouldWatch }))
   .post('/results', (req, res) => {
     req.on('data', (chunk: Buffer) => {
+      // eslint-disable-next-line no-console
       console.log(chunk.toString())
     })
     req.on('close', () => {

diff --git a/src/content/browser/components/tabs/tab.ts b/src/content/browser/components/tabs/tab.ts
@@ -305,21 +305,21 @@ class TabProgressListener
     aStatus: number,
     aMessage: string,
   ): void {
-    console.log('onStatusChange')
+    // console.log('onStatusChange')
   }
   onSecurityChange(
     aWebProgress: nsIWebProgressType,
     aRequest: nsIRequestType,
     aState: number,
   ): void {
-    console.log('onSecurityChange')
+    // console.log('onSecurityChange')
   }
   onContentBlockingEvent(
     aWebProgress: nsIWebProgressType,
     aRequest: nsIRequestType,
     aEvent: number,
   ): void {
-    console.log('onContentBlockingEvent')
+    // console.log('onContentBlockingEvent')
   }
 
   QueryInterface = ChromeUtils.generateQI([

diff --git a/src/content/browser/lib/shortcuts.ts b/src/content/browser/lib/shortcuts.ts
@@ -33,7 +33,7 @@ export function initializeShortcuts() {
         runOnCurrentTab((tab) => tab.goForward())
         break
       default:
-        console.log(event)
+        console.warn('Unknown event', event)
     }
   })
 }
diff --git a/src/content/browser/lib/xul/browser.ts b/src/content/browser/lib/xul/browser.ts
@@ -7,8 +7,6 @@ const { useRemoteTabs, useRemoteSubframe } = window.docShell.QueryInterface(
   Ci.nsILoadContext,
 )
 
-console.log(useRemoteTabs, useRemoteSubframe)
-
 const DEFAULT_BROWSER_ATTRIBUTES = {
   message: 'true',
   messagemanagergroup: 'browsers',

diff --git a/src/modules/BrowserGlue.ts b/src/modules/BrowserGlue.ts
@@ -50,14 +50,13 @@ export class BrowserGlue {
   QueryInterface = ChromeUtils.generateQI(['nsIObserver'])
 
   constructor() {
-    console.log('BrowserGlue impl')
-
     lazy.ActorManagerParent.addJSProcessActors(JS_PROCESS_ACTORS)
     lazy.ActorManagerParent.addJSWindowActors(JS_WINDOW_ACTORS)
   }
 
   // nsIObserver impl
   observe(aSubject: nsISupportsType, aTopic: string, aData: string): void {
+    // eslint-disable-next-line no-console
     console.log({ aSubject, aTopic, aData })
   }
 }
diff --git a/src/modules/FaviconLoader.ts b/src/modules/FaviconLoader.ts
@@ -624,6 +624,7 @@ class IconLoader {
     } catch (e: any) {
       if (e.result != Cr.NS_BINDING_ABORTED) {
         if (typeof e.data?.wrappedJSObject?.httpStatus !== 'number') {
+          // eslint-disable-next-line no-console
           console.error(e)
         }