Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move migration support to provider-ci #1150

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Conversation

danielrbradley
Copy link
Member

Move away from the typescript scripts which are only run during push but not from the make ci-mgmt target. This ensures migrations are run in both the pull and push styles consistently.

  • Migrate existing migrations.
  • Remove old typescript code.
  • Remove old step in CI.
  • Skip running migrations for local test-providers as they have no code in them and will fail most of the time.

Move away from the typescript scripts which are only run during push but not from the `make ci-mgmt` target.
Local test repos have no files so fail most migrations.
Just drop migration step as this is included when running provider-ci.
@danielrbradley danielrbradley self-assigned this Nov 21, 2024
@danielrbradley danielrbradley changed the title Add migration support to provider-ci Move migration support to provider-ci Nov 21, 2024
@danielrbradley danielrbradley requested a review from a team November 21, 2024 10:28
@danielrbradley
Copy link
Member Author

danielrbradley commented Nov 21, 2024

Any suggestions on why embed works perfectly for me locally but seems to be failing in CI most welcome!

It was case sensitivity in the filename

Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better.

@danielrbradley danielrbradley added this pull request to the merge queue Nov 22, 2024
Merged via the queue into master with commit 4af8e48 Nov 22, 2024
6 checks passed
@danielrbradley danielrbradley deleted the provider-ci-migrations branch November 22, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants