Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove minimal schema from source #4829

Merged
merged 6 commits into from
Nov 26, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Nov 25, 2024

Keeping a copy of minimal schema (introduced in #4587) is proving to conflict with Pulumi tooling such as upgrade-provider and is not strictly necessary. With this change the minimal schema itself as well as CI checks to make sure it is up to date are removed. Instead it will be computed on-the-fly by the release job as before:

Fixes:


//go:embed schema-minimal-embed.json
var pulumiMinimalSchema []byte
//go:embed schema-*-embed.json
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The advantage of the * is that code still compiles even when minimal schema is not present on disk (such as upon checkout).

@t0yv0 t0yv0 requested a review from corymhall November 25, 2024 20:59
@t0yv0
Copy link
Member Author

t0yv0 commented Nov 26, 2024

I need one more tweak, but I think this can work.

@t0yv0 t0yv0 force-pushed the t0yv0/remove-minimal-schema-from-source branch from c530820 to c4d62fe Compare November 26, 2024 15:52
@t0yv0 t0yv0 enabled auto-merge (squash) November 26, 2024 15:52
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@t0yv0 t0yv0 merged commit ea37dae into master Nov 26, 2024
32 checks passed
@t0yv0 t0yv0 deleted the t0yv0/remove-minimal-schema-from-source branch November 26, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants