-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove minimal schema from source #4829
Conversation
|
||
//go:embed schema-minimal-embed.json | ||
var pulumiMinimalSchema []byte | ||
//go:embed schema-*-embed.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The advantage of the *
is that code still compiles even when minimal schema is not present on disk (such as upon checkout).
I need one more tweak, but I think this can work. |
c530820
to
c4d62fe
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Keeping a copy of minimal schema (introduced in #4587) is proving to conflict with Pulumi tooling such as
upgrade-provider
and is not strictly necessary. With this change the minimal schema itself as well as CI checks to make sure it is up to date are removed. Instead it will be computed on-the-fly by the release job as before:GitHub actions invoke this:
pulumi-aws/.github/workflows/build_provider.yml
Line 60 in 916e6f2
Make extension ensures that this runs go generate prior to the actual build so that the minimal schema is re-computed:
pulumi-aws/.mk/minimal_schema.mk
Line 9 in 916e6f2
Fixes: